This revision was automatically updated to reflect the committed changes.
Closed by commit R240:24538afeaf61: Detect duplicate ANDROID_EXTRA_LIBS and
minor bug fix (authored by sh-zam).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20509?vs=56244&
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Looks good to me, can you land it?
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D20509
To: sh-zam, apol, vkrause
Cc: kde-buildsystem, kd
sh-zam marked 2 inline comments as done.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D20509
To: sh-zam, apol, vkrause
Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns
sh-zam updated this revision to Diff 56244.
sh-zam added a comment.
improved name and code flow
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20509?vs=56151&id=56244
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D20509
AFFECT
apol requested changes to this revision.
apol added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> ECMAndroidDeployQt.cmake:41
> if (NOT VALUE STREQUAL "")
> -string(FIND "${VALUE}" ".so\"" OUT)
> -math(EXPR OUT "${OUT}+4")
> -
lbeltrame added reviewers: apol, vkrause.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D20509
To: sh-zam, apol, vkrause
Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns
sh-zam updated this revision to Diff 56151.
sh-zam added a comment.
minor typo fixed
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20509?vs=56146&id=56151
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D20509
AFFECTED FILES
sh-zam created this revision.
Herald added projects: Frameworks, Build System.
Herald added a subscriber: kde-buildsystem.
sh-zam requested review of this revision.
REVISION SUMMARY
Don't include same dependency twice, one which was found
from `readelf` in `specifydependencies.cmake` and other
