D20565: Ensure not to fold the end marker

2019-04-20 Thread loh tar
loh.tar abandoned this revision. loh.tar added a comment. Patch is part of D20606 > And happy Easter ;=) Thank you! :-) REVISION DETAIL https://phabricator.kde.org/D20565 To: loh.tar, #ktexteditor, cullmann, dhaumann, ngraham Cc: kwrite-devel,

D20565: Ensure not to fold the end marker

2019-04-19 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. You can submit that, perhaps with the discussed checks, thanks And happy Easter ;=) REVISION DETAIL https://phabricator.kde.org/D20565 To: loh.tar, #ktexteditor, cullmann, dhaumann, ngraham Cc: kwrite-devel, kde-frameworks-devel,

D20565: Ensure not to fold the end marker

2019-04-16 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Yes, I am in favor. thanks REVISION DETAIL https://phabricator.kde.org/D20565 To: loh.tar, #ktexteditor, cullmann, dhaumann, ngraham Cc: kwrite-devel, kde-frameworks-devel, #ktextedit

D20565: Ensure not to fold the end marker

2019-04-15 Thread Christoph Cullmann
cullmann added reviewers: dhaumann, ngraham. cullmann added a comment. I like the idea, its nice for e.g. if then else cascades, you get then out of stuff like if (blockwise || range.onSingleLine()) { lineStart = range.start().column(); remainingChars = range.columnWidth

D20565: Ensure not to fold the end marker

2019-04-15 Thread loh tar
loh.tar updated this revision to Diff 56306. loh.tar edited the test plan for this revision. loh.tar added a comment. - Adjust only on token based folding CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20565?vs=56267&id=56306 REVISION DETAIL https://phabricator.kde.org/D20565 AFF

D20565: Ensure not to fold the end marker

2019-04-14 Thread loh tar
loh.tar created this revision. loh.tar added reviewers: KTextEditor, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY ...to avoid a deceptive look With recent fixes wa