D20626: Rely upon QSysInfo to retrieve the system details

2019-05-21 Thread David Faure 
dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20626

To: shubham, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20626: Rely upon QSysInfo to retrieve the system details

2019-05-20 Thread Shubham 
shubham updated this revision to Diff 58369.
shubham added a comment.


  -

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20626?vs=58354=58369

BRANCH
  sysinfo

REVISION DETAIL
  https://phabricator.kde.org/D20626

AFFECTED FILES
  src/kcms/kio/useragentinfo.cpp

To: shubham, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20626: Rely upon QSysInfo to retrieve the system details

2019-05-20 Thread Shubham 
shubham added a comment.


  @dfaure Would you mind commiting it, I think I just messes up my ssh keys

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D20626

REVISION DETAIL
  https://phabricator.kde.org/D20626

To: shubham, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20626: Rely upon QSysInfo to retrieve the system details

2019-05-20 Thread David Faure 
dfaure added a comment.


  Thanks. You can land the commit.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D20626

REVISION DETAIL
  https://phabricator.kde.org/D20626

To: shubham, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20626: Rely upon QSysInfo to retrieve the system details

2019-05-20 Thread Shubham 
shubham updated this revision to Diff 58354.
shubham edited the summary of this revision.
shubham added a comment.


  proper rebase

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20626?vs=58351=58354

BRANCH
  arcpatch-D20626

REVISION DETAIL
  https://phabricator.kde.org/D20626

AFFECTED FILES
  src/kcms/kio/useragentinfo.cpp

To: shubham, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20626: Rely upon QSysInfo to retrieve the system details

2019-05-20 Thread Shubham 
shubham retitled this revision from "Refactor and cleanup" to "Rely upon 
QSysInfo to retrieve the system details".
shubham edited the summary of this revision.
shubham edited the test plan for this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D20626

REVISION DETAIL
  https://phabricator.kde.org/D20626

To: shubham, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns