D20639: Remove TODO

2019-04-17 Thread Shubham
shubham abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20639 To: shubham, dfaure, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20639: Remove TODO

2019-04-17 Thread Aleix Pol Gonzalez
apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. I don't think you understood the TODO. Also this change breaks ABI, since const it's part of it. The TODO talks about adding a startTimer method and deprecating timer (which it alre

D20639: Remove TODO

2019-04-17 Thread Shubham
shubham created this revision. shubham added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REPOSITORY R241 KIO BRANCH todo REVISION DETAIL https://phabricator.kde.org/D20639 AFFECTED FILE