D20659: Detach container in Component::cleanUp before interating

2019-04-18 Thread Fabian Vogt
fvogt edited the summary of this revision. fvogt edited the test plan for this revision. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D20659 To: fvogt, #frameworks Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D20659: Detach container in Component::cleanUp before interating

2019-04-18 Thread Luca Beltrame
lbeltrame added a comment. I confirm there are no more issues in valgrind after adding this patch. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D20659 To: fvogt, #frameworks Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D20659: Detach container in Component::cleanUp before interating

2019-04-18 Thread Luca Beltrame
lbeltrame added a reviewer: Frameworks. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D20659 To: fvogt, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20659: Detach container in Component::cleanUp before interating

2019-04-18 Thread Fabian Vogt
fvogt updated this revision to Diff 56517. fvogt added a comment. Use auto (which might actually make it build) REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20659?vs=56515&id=56517 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2065

D20659: Detach container in Component::cleanUp before interating

2019-04-18 Thread Fabian Vogt
fvogt created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY Might fix crashes similiar to bug 406426 TEST PLAN Not tested, will ask someone to do that with valgrind REPOSITORY R2