D20708: Change input-* device icon styles, add 16px icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:2078a10ea1b0: Change input-* device icon styles, add 16px icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20708?vs=58047=58138

D20708: Change input-* device icon styles, add 16px icons

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH input-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D20708 To: ndavis, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20708: Change input-* device icon styles, add 16px icons

ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20708 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20708: Change input-* device icon styles, add 16px icons

ndavis updated this revision to Diff 58047. ndavis added a comment. Add new dialog-input-devices icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20708?vs=56657=58047 BRANCH input-icons (branched from master) REVISION DETAIL

D20708: Change input-* device icon styles, add 16px icons

ngraham added a comment. I think that looks good! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20708 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20708: Change input-* device icon styles, add 16px icons

ndavis added a comment. In D20708#454298 , @ngraham wrote: > Even if only Inkscape currently uses the icon, as a rule we ignore that kind of information for code/content in Frameworks, because //in principle// any app could use it. It's more

D20708: Change input-* device icon styles, add 16px icons

ngraham added a comment. Even if only Inkscape currently uses the icon, as a rule we ignore that kind of information for code/content in Frameworks, because //in principle// any app could use it. It's more important for the icon to be semantically correct for any app that wants to use it

D20708: Change input-* device icon styles, add 16px icons

ndavis added a comment. Actually, `dialog-input-devices` is used by inkscape for configuring pointing devices and tablets. AFAIK, only Inkscape uses that icon. If I made it show more types of devices, it would be more accurate to use a tablet. Looking at the Input Devices dock in Inkscape,

D20708: Change input-* device icon styles, add 16px icons

ndavis added a comment. In D20708#453690 , @ngraham wrote: > Overall very nice. > > Instead of symlinking `input-mouse` to `dialog-input-devices`, I think it might make more sense to rename `dialog-input-devices` to be `input-mouse` and

D20708: Change input-* device icon styles, add 16px icons

ngraham added a comment. Overall very nice. Instead of symlinking `input-mouse` to `dialog-input-devices`, I think it might make more sense to rename `dialog-input-devices` to be `input-mouse` and then change the `dialog-input-devices` so that it depicts more than one input device, to

D20708: Change input-* device icon styles, add 16px icons

ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20708 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20708: Change input-* device icon styles, add 16px icons

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY `devices/16` was missing some `input-*` icons. `input-keyboard-virtual` looked more like