D20914: [TaglibExtractor] Feed non-ogg *.spx file into extractor test

2019-04-30 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:c14869f1b9af: [TaglibExtractor] Feed non-ogg *.spx file 
into extractor test (authored by bruns).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20914?vs=57230=57282

REVISION DETAIL
  https://phabricator.kde.org/D20914

AFFECTED FILES
  autotests/samplefiles/misdetected/test_arcgis_geodata.spx
  autotests/taglibextractortest.cpp
  autotests/taglibextractortest.h

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20914: [TaglibExtractor] Feed non-ogg *.spx file into extractor test

2019-04-30 Thread Alexander Stippich 
astippich accepted this revision.

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20914

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20914: [TaglibExtractor] Feed non-ogg *.spx file into extractor test

2019-04-30 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice.

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20914

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20914: [TaglibExtractor] Feed non-ogg *.spx file into extractor test

2019-04-29 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Binary files with .spx extension are detected as audio/speex as the type
  has no file magic. Taglib will crash when trying to extract properties
  from these files. ArcGIS datasets contain affected binary files.

TEST PLAN
  ctest

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20914

AFFECTED FILES
  autotests/samplefiles/misdetected/test_arcgis_geodata.spx
  autotests/taglibextractortest.cpp
  autotests/taglibextractortest.h

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams