D20924: [WIP] ViewConfig: Use new generic config interface
loh.tar updated this revision to Diff 57346. loh.tar edited the summary of this revision. loh.tar added a comment. - BookmarkSorting - AutoCenterLines - DefaultMarkType - PersistentSelection - InputMode - ViInputModeStealKeys - ViRelativeLineNumbers - AutomaticCompletionInvocation - WordCompletion - KeywordCompletion - WordCompletionMinimalWordLength - WordCompletionRemoveTail 7 more and we are done :-/ CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20924?vs=57323&id=57346 REVISION DETAIL https://phabricator.kde.org/D20924 AFFECTED FILES autotests/src/katedocument_test.cpp autotests/src/kateview_test.cpp autotests/src/vimode/base.cpp autotests/src/vimode/completion.cpp autotests/src/vimode/emulatedcommandbarsetupandteardown.cpp autotests/src/vimode/keys.cpp autotests/src/vimode/view.cpp src/dialogs/katedialogs.cpp src/document/katedocument.cpp src/search/katesearchbar.cpp src/utils/kateconfig.cpp src/utils/kateconfig.h src/view/kateview.cpp src/view/kateviewhelpers.cpp src/vimode/config/configtab.cpp To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars
D20924: [WIP] ViewConfig: Use new generic config interface
loh.tar updated this revision to Diff 57323. loh.tar edited the summary of this revision. loh.tar added a comment. - Use the power of new the interface in DocumentPrivate::setViewVariable - ShowFoldingPreview - ShowLineModification - ShowFoldingBar CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20924?vs=57309&id=57323 REVISION DETAIL https://phabricator.kde.org/D20924 AFFECTED FILES autotests/src/katedocument_test.cpp autotests/src/vimode/base.cpp autotests/src/vimode/view.cpp src/dialogs/katedialogs.cpp src/document/katedocument.cpp src/search/katesearchbar.cpp src/utils/kateconfig.cpp src/utils/kateconfig.h src/view/kateview.cpp To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars
D20924: [WIP] ViewConfig: Use new generic config interface
loh.tar updated this revision to Diff 57309. loh.tar edited the summary of this revision. loh.tar added a comment. - Use the power of new the interface in ViewPrivate::setConfigValue - Add missed finalizeConfigEntries() call - Add check to finalizeConfigEntries() for key to be unique - ShowIconBar - ShowScrollbars CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20924?vs=57300&id=57309 REVISION DETAIL https://phabricator.kde.org/D20924 AFFECTED FILES autotests/src/katedocument_test.cpp autotests/src/vimode/base.cpp autotests/src/vimode/view.cpp src/dialogs/katedialogs.cpp src/document/katedocument.cpp src/search/katesearchbar.cpp src/utils/kateconfig.cpp src/utils/kateconfig.h src/view/kateview.cpp To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars
D20924: [WIP] ViewConfig: Use new generic config interface
loh.tar updated this revision to Diff 57300. loh.tar edited the summary of this revision. loh.tar added a comment. - Rebase on master - ShowScrollBarMiniMap - ShowScrollBarMiniMapAll - ScrollBarMiniMapWidth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20924?vs=57293&id=57300 REVISION DETAIL https://phabricator.kde.org/D20924 AFFECTED FILES autotests/src/katedocument_test.cpp autotests/src/vimode/base.cpp src/dialogs/katedialogs.cpp src/document/katedocument.cpp src/search/katesearchbar.cpp src/utils/kateconfig.cpp src/utils/kateconfig.h src/view/kateview.cpp To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars
D20924: [WIP] ViewConfig: Use new generic config interface
loh.tar added inline comments. INLINE COMMENTS > dhaumann wrote in kateconfig.h:964 > Are training commas allowed meanwhile? Yes. It's handy while still on work here, but can remove it when I'm done, if desired. Thanks for your look, pls do it again later. REVISION DETAIL https://phabricator.kde.org/D20924 To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars
D20924: [WIP] ViewConfig: Use new generic config interface
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I read the diff carefully, please commit. INLINE COMMENTS > kateconfig.h:964 > +ShowScrollBarPreview, > +ShowWordCount, > }; Are training commas allowed meanwhile? REVISION DETAIL https://phabricator.kde.org/D20924 To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars
D20924: [WIP] ViewConfig: Use new generic config interface
loh.tar updated this revision to Diff 57293. loh.tar edited the summary of this revision. loh.tar added a comment. - ShowScrollBarPreview - ShowScrollBarMarks - ShowLineNumbers - Add some validator functions, please look at them CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20924?vs=57285&id=57293 REVISION DETAIL https://phabricator.kde.org/D20924 AFFECTED FILES autotests/src/katedocument_test.cpp autotests/src/vimode/base.cpp src/dialogs/katedialogs.cpp src/document/katedocument.cpp src/search/katesearchbar.cpp src/utils/kateconfig.cpp src/utils/kateconfig.h src/view/kateview.cpp To: loh.tar, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D20924: [WIP] ViewConfig: Use new generic config interface
loh.tar added a comment. Ah, last hint: The diff is not against master. Should you really like to try it, I can fix that earlier, otherwise will do it when I'm done REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20924 To: loh.tar, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D20924: [WIP] ViewConfig: Use new generic config interface
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Done so far: - DynWordWrapAlignIndent - DynWordWrapIndicators - DynWrapAtStaticMarker - DynamicWordWrap - ShowWordCount - MaxHistorySize - SearchFlags - BackspaceRemoveComposedCharacters TEST PLAN Please take a look, point me to mistakes, but wait until WIP is gone for a final "OK" REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20924 AFFECTED FILES autotests/src/katedocument_test.cpp src/dialogs/katedialogs.cpp src/search/katesearchbar.cpp src/utils/kateconfig.cpp src/utils/kateconfig.h src/view/kateview.cpp To: loh.tar, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
