D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f066660f: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited… (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20964?v

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

ngraham added inline comments. INLINE COMMENTS > pino wrote in kfilewidget.cpp:2804-2806 > why is this limited to the saving mode? you can perfectly use a mimetype > filter when opening files When opening, the mimetype chooser still has filtering functionality and isn't a drop-down menu combob

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

pino added inline comments. INLINE COMMENTS > kfilewidget.cpp:2804-2806 > +if (operationMode == KFileWidget::Saving && > filterWidget->isMimeFilter()) { > +label = i18n("&File type:"); > +whatsThisText = i18n("This is the file type selector. It is used > to select the format

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

ngraham added a comment. Yep, will do. Thanks! REPOSITORY R241 KIO BRANCH file-type-when-saving-and-mimetype-is-defined (branched from master) REVISION DETAIL https://phabricator.kde.org/D20964 To: ngraham, #vdg, elvisangelaccio, GB_2 Cc: apol, kde-frameworks-devel, michaelh, ngraham,

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

elvisangelaccio accepted this revision. elvisangelaccio added a comment. This revision is now accepted and ready to land. Please wait the tagging before pushing. REPOSITORY R241 KIO BRANCH file-type-when-saving-and-mimetype-is-defined (branched from master) REVISION DETAIL https://phab

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

ngraham updated this revision to Diff 57517. ngraham added a comment. Fix typo in comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20964?vs=57516&id=57517 BRANCH file-type-when-saving-and-mimetype-is-defined (branched from master) REVISION DETAIL ht

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

ngraham updated this revision to Diff 57516. ngraham marked an inline comment as done. ngraham added a comment. Don't forget to set the parent REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20964?vs=57493&id=57516 BRANCH file-type-when-saving-and-mimetype-is

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

apol added a comment. +1 looks good to me besides the nitpick. INLINE COMMENTS > kfilewidget.cpp:594 > // the Filter label/edit > -whatsThisText = i18n("This is the filter to apply to the file list. " > - "File names that do not match the filter will not > be

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

ngraham updated this revision to Diff 57492. ngraham marked 3 inline comments as done. ngraham added a comment. Put it in a function and then call that function in all the places where things might change REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20964?vs

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

ngraham updated this revision to Diff 57493. ngraham added a comment. Revert unintentional change to `KFileWidget::currentMimeFilter()` REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20964?vs=57492&id=57493 BRANCH file-type-when-saving-and-mimetype-is-define

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

apol added inline comments. INLINE COMMENTS > ngraham wrote in kfilewidget.cpp:745 > I did it in `setMimeFilter` since that's where it's determined whether or not > there's a limited assortment of mimetypes, which is what controls what the > string should be. Conditionalizing it based on mode s

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20964 To: ngraham, #vdg, elvisangelaccio, GB_2 Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

ngraham added inline comments. INLINE COMMENTS > apol wrote in kfilewidget.cpp:745 > Isn't it a bit weird to do this in setMimeFilter? I did it in `setMimeFilter` since that's where it's determined whether or not there's a limited assortment of mimetypes, which is what controls what the string

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

apol added inline comments. INLINE COMMENTS > kfilewidget.cpp:745 > + > +if (d->operationMode == Saving) { > +d->filterLabel->setText(i18n("&File type:")); Isn't it a bit weird to do this in setMimeFilter? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20964

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

ngraham created this revision. ngraham added reviewers: VDG, elvisangelaccio, GB_2. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY The Filter combobox currently always has the label "Filter:" This i