D20984: Add ECMAddQmlModule

2019-10-08 Thread Friedrich W. H. Kossebau 
kossebau added a dependent revision: D21356: Port to ECMAddQmlModule, add 
plugins.qmltypes files.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D20984

To: kossebau, #plasma, apol
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D20984: Add ECMAddQmlModule

2019-10-08 Thread Friedrich W. H. Kossebau 
kossebau added a dependent revision: D21344: Port to ECMAddQmlModule.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D20984

To: kossebau, #plasma, apol
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D20984: Add ECMAddQmlModule

2019-10-08 Thread Friedrich W. H. Kossebau 
kossebau abandoned this revision.
kossebau added a comment.


  @apol Thanks again for your review work.
  
  I am still a bit unsure about the usefulness and completeness of this macro, 
even more as I would not call myself a QML expert who has seen all corners. And 
given the lack of feedback from more QML using developers here, I fear this 
macro might also have a chance of being done because it could be, not because 
it improves developer experience of those who would use it.
  
  Myself I currently have no use for it in projects I contribute to. So to not 
add a macro which only bloats the size of ECM and adds more maintenance burden, 
I for now abandon this code. If someone else still is interested, please do not 
hesitate to take over.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D20984

To: kossebau, #plasma, apol
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D20984: Add ECMAddQmlModule

2019-06-12 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  addinstallqmlplugin

REVISION DETAIL
  https://phabricator.kde.org/D20984

To: kossebau, #plasma, apol
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, bencreasy, 
michaelh, ngraham, bruns

D20984: Add ECMAddQmlModule

2019-06-12 Thread Friedrich W. H. Kossebau 
kossebau updated this revision to Diff 59700.
kossebau added a comment.


  - add options to take identifiers/type names from file base names
  - add option to specify version suffix to install path

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20984?vs=58490=59700

BRANCH
  addinstallqmlplugin

REVISION DETAIL
  https://phabricator.kde.org/D20984

AFFECTED FILES
  docs/module/ECMAddQmlModule.rst
  modules/ECMAddQmlModule.cmake

To: kossebau, #plasma
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, bencreasy, 
michaelh, ngraham, bruns

D20984: Add ECMAddQmlModule

2019-05-22 Thread Friedrich W. H. Kossebau 
kossebau retitled this revision from "Add ECMInstallQmlModules, with 
ecm_install_qmlplugin as start" to "Add ECMAddQmlModule".
kossebau edited the summary of this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D20984

To: kossebau, #plasma
Cc: apol, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, 
bruns