D21002: Remove kde4 migration agent completely

2019-07-20 Thread Luca Beltrame
lbeltrame closed this revision. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham, aacid Cc: siddharthasahu, aacid, lbeltrame, kde-frameworks-devel, damjang, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21002: Remove kde4 migration agent completely

2019-07-20 Thread Luca Beltrame
lbeltrame added a comment. Should be fixed with ff6b077d9200856dc6e393a04c6b3ae82d9792ed . REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham, aacid

D21002: Remove kde4 migration agent completely

2019-07-20 Thread Luca Beltrame
lbeltrame reopened this revision. lbeltrame added a comment. This revision is now accepted and ready to land. This breaks GPG wallets completely. They are no longer accounted for by kwalletd: reverting this change makes them work again. REPOSITORY R311 KWallet REVISION DETAIL

D21002: Remove kde4 migration agent completely

2019-07-18 Thread Siddhartha Sahu
siddharthasahu added a comment. Do I have to reset something on my machine after this? I'm am running frameworks and plasma from git master, and with this commit, kwalled does not seem to working for me. Kwallet manager starts with a empty window and applications (ssh agent and

D21002: Remove kde4 migration agent completely

2019-07-17 Thread Stefan Brüns
bruns added a comment. It tried to install the no longer existing DBus service file. Fixup pushed. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham, aacid Cc: aacid, lbeltrame, kde-frameworks-devel, damjang, LeGast00n,

D21002: Remove kde4 migration agent completely

2019-07-17 Thread Albert Astals Cid
aacid added a comment. It seems you broke the build https://build.kde.org/job/Frameworks/job/kwallet/ is all read REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham, aacid Cc: aacid, lbeltrame,

D21002: Remove kde4 migration agent completely

2019-07-17 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R311:dc5c7229bc4f: Remove kde4 migration agent completely (authored by bruns). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21002?vs=57489=61943 REVISION DETAIL

D21002: Remove kde4 migration agent completely

2019-07-16 Thread Albert Astals Cid
aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. i guess 路 REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham, aacid Cc: aacid, lbeltrame,

D21002: Remove kde4 migration agent completely

2019-07-05 Thread Stefan Brüns
bruns added a comment. Can I have a "go"? REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham Cc: aacid, lbeltrame, kde-frameworks-devel, damjang, LeGast00n, michaelh, ngraham, bruns

D21002: Remove kde4 migration agent completely

2019-06-10 Thread Nathaniel Graham
ngraham added a comment. Yeah, seems like the existing migration is just broken, so we might as well remove it. :/ REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham Cc: aacid, lbeltrame, kde-frameworks-devel, damjang,

D21002: Remove kde4 migration agent completely

2019-06-10 Thread Albert Astals Cid
aacid added a comment. I'm pretty sure there's people there still using KDE4 (real life scenario: my father) (almost real life scenario: i know the Limux people were planning a migration from kde4 to Plasma 5, not sure if it already happened or not though). Eventually he'll move to a

D21002: Remove kde4 migration agent completely

2019-06-09 Thread Luca Beltrame
lbeltrame added a comment. +1 REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham Cc: lbeltrame, kde-frameworks-devel, damjang, LeGast00n, michaelh, ngraham, bruns

D21002: Remove kde4 migration agent completely

2019-06-09 Thread Stefan Brüns
bruns added a comment. Ping! REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham Cc: kde-frameworks-devel, damjang, LeGast00n, michaelh, ngraham, bruns

D21002: Remove kde4 migration agent completely

2019-06-09 Thread Stefan Brüns
bruns added a reviewer: ngraham. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham Cc: kde-frameworks-devel, damjang, LeGast00n, michaelh, ngraham, bruns

D21002: Remove kde4 migration agent completely

2019-05-03 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Frameworks, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The migration agent is some quite weird mechanism: - it starts the KDE4