D21007: Review kate config pages to improve maintenance friendliness
This revision was automatically updated to reflect the committed changes. Closed by commit R39:2af8bdae9ae2: Review kate config pages to improve maintenance friendliness (authored by loh.tar). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21007?vs=57518=57522#toc REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21007?vs=57518=57522 REVISION DETAIL https://phabricator.kde.org/D21007 AFFECTED FILES src/dialogs/kateconfigpage.cpp src/dialogs/kateconfigpage.h src/dialogs/katedialogs.cpp To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars
D21007: Review kate config pages to improve maintenance friendliness
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I guess this is more easy on the eyes. Alternatively, one could consider making observeCanges a free function, but please commit for now. INLINE COMMENTS > katedialogs.cpp:156 > +// NOTE Should we have more use of such info stuff, consider to make it part > +// of KateConfigPage and add a sililar function like observeChanges(..) > void KateIndentConfigTab::showWhatsThis(const QString ) Typo: sililar REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21007 To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars
D21007: Review kate config pages to improve maintenance friendliness
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Use new signal/slot style by new added helper functions - Unified comments, added some new, removed some obsolete TEST PLAN I hope nothing got damaged REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21007 AFFECTED FILES src/dialogs/kateconfigpage.cpp src/dialogs/kateconfigpage.h src/dialogs/katedialogs.cpp To: loh.tar, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
