D21078: Avoid infinite loop in "Toggle Contained Nodes" action

2019-05-08 Thread loh tar 
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:783647154a0e: Avoid infinite loop in "Toggle 
Contained Nodes" action (authored by loh.tar).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21078?vs=57747&id=57772#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21078?vs=57747&id=57772

REVISION DETAIL
  https://phabricator.kde.org/D21078

AFFECTED FILES
  src/document/katebuffer.cpp
  src/view/kateview.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D21078: Avoid infinite loop in "Toggle Contained Nodes" action

2019-05-08 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok ;=)
  Thanks for quick fix.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21078

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D21078: Avoid infinite loop in "Toggle Contained Nodes" action

2019-05-07 Thread loh tar 
loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

TEST PLAN
  Try and empty folding range like 
  ktexteditor/src/utils/kateconfig.cpp:634
  
  Where...
  
  KateRendererConfig::~KateRendererConfig()
  {
  }
  
  ...cause the hassle
  
  Each part of this patch solve the issue of its own, but I'm unsure which way 
to go. 
  I think it shouldn't be a folding range offered in such a case, will look at 
it later.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21078

AFFECTED FILES
  src/document/katebuffer.cpp
  src/view/kateview.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann