D21126: [KUiServerJobTracker] Register jobs asynchronously

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  I've got a jobviewv2 thing in the works which is qvariantmap-based so it can 
easily queue any changes and send them out once registered. I think jobviewv1 
should just stay as is and be phased out eventually, cf. T12574 


REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D21126

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D21126: [KUiServerJobTracker] Register jobs asynchronously

[Kai Uwe Broulik]

broulik updated this revision to Diff 57864.
broulik added a comment.


  - When reply comes in after job already finished, call terminate on the 
jobview to end it gracefully

REPOSITORY
  R288 KJobWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21126?vs=57862&id=57864

REVISION DETAIL
  https://phabricator.kde.org/D21126

AFFECTED FILES
  src/kuiserverjobtracker.cpp
  src/kuiserverjobtracker.h

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21126: [KUiServerJobTracker] Register jobs asynchronously

[Kai Uwe Broulik]

broulik planned changes to this revision.
broulik added a comment.


  However now it obviously misses the first calls to set message and what not 
because the job view doesn't yet exist there...

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D21126

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21126: [KUiServerJobTracker] Register jobs asynchronously

[Kai Uwe Broulik]

broulik edited the summary of this revision.

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D21126

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21126: [KUiServerJobTracker] Register jobs asynchronously

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, dfaure, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Don't block waiting for the server to register the job, especially since it 
is typically only shown after 500ms anyway.

TEST PLAN
  Froze the server, app didn't block waiting in the register call anymore.
  Let the job finish and then unfroze the app, got a reply but it found the job 
already deleted and didn't do anything and didn't crash.

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D21126

AFFECTED FILES
  src/kuiserverjobtracker.cpp
  src/kuiserverjobtracker.h

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns