D21169: Add app icon for the Kirogi Drone control app

2019-09-21 Thread Phabricator 
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:faff4ff246af: Add app icon for the Kirogi Drone control 
app (authored by Rafael Brandmaier rafael.brandma...@kdemail.net).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21169?vs=66594=66595

REVISION DETAIL
  https://phabricator.kde.org/D21169

AFFECTED FILES
  icons-dark/apps/48/kirogi.svg
  icons/apps/48/kirogi.svg

To: trickyricky26, hein, #vdg, ngraham
Cc: ognarb, ngraham, apol, kde-frameworks-devel, hein, LeGast00n, GB_2, 
michaelh, bruns

D21169: Add app icon for the Kirogi Drone control app

2019-09-21 Thread TrickyRicky 
trickyricky26 updated this revision to Diff 66594.
trickyricky26 added a comment.


  - A tiny bit more optimized

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21169?vs=57954=66594

BRANCH
  kirogi-app-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21169

AFFECTED FILES
  icons-dark/apps/48/kirogi.svg
  icons/apps/48/kirogi.svg

To: trickyricky26, hein, #vdg, ngraham
Cc: ognarb, ngraham, apol, kde-frameworks-devel, hein, LeGast00n, GB_2, 
michaelh, bruns

D21169: Add app icon for the Kirogi Drone control app

2019-09-21 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Shipit!

REPOSITORY
  R266 Breeze Icons

BRANCH
  kirogi-app-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21169

To: trickyricky26, hein, #vdg, ngraham
Cc: ognarb, ngraham, apol, kde-frameworks-devel, hein, LeGast00n, GB_2, 
michaelh, bruns

D21169: Add app icon for the Kirogi Drone control app

2019-09-21 Thread Carl Schwan 
ognarb added a comment.


  kde.org/applications use the icons from breeze-icons. So I think it's worth 
adding to breeze-icons or improving how the icon are fetched in 
kde.org/applications.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21169

To: trickyricky26, hein, #vdg
Cc: ognarb, ngraham, apol, kde-frameworks-devel, hein, LeGast00n, GB_2, 
michaelh, bruns

D21169: Add app icon for the Kirogi Drone control app

2019-09-21 Thread TrickyRicky 
trickyricky26 added a comment.


  Should I land this or abandon it?
  It doesn't really make a difference if the icon is in Breeze in addition to 
being shipped with the app, but IMO it would also be strange to not have this 
Breeze-style icon for a KDE app in Breeze.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21169

To: trickyricky26, hein, #vdg
Cc: ngraham, apol, kde-frameworks-devel, hein, LeGast00n, GB_2, michaelh, bruns

D21169: Add app icon for the Kirogi Drone control app

2019-05-13 Thread Nathaniel Graham 
ngraham added a comment.


  the icon theme can be considered to be VDG-maintained these days, andI think 
this passes the visual design test, but also the most important thing is that 
you as the app author like it!
  
  However if this is the actual icon you want to ship with the app, do we even 
need it to be in the breeze-icons framework? If it's the exact same icon, and 
you're going to ship it in your app's packaging/bundle anyway, I'm wondering 
what the value is.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21169

To: trickyricky26, hein, #vdg
Cc: ngraham, apol, kde-frameworks-devel, hein, michaelh, bruns

D21169: Add app icon for the Kirogi Drone control app

2019-05-13 Thread Eike Hein 
hein added a comment.


  I'd say it's up to the Breeze maintainers. From my end I'm very interested in 
the app having a Breeze-compatible icon, because I'd like it to integrate well 
with KDE's workspaces and other apps. Review by the Breeze community is very 
appreciated to help with that. Application code needs to ship the icon anyway 
though for systems that don't have the theme and can't be reasonably expected 
to provide every app icon, so it's not vital to be included with the theme.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21169

To: trickyricky26, hein, #vdg
Cc: ngraham, apol, kde-frameworks-devel, hein, michaelh, bruns

D21169: Add app icon for the Kirogi Drone control app

2019-05-13 Thread Nathaniel Graham 
ngraham added a comment.


  In D21169#464291 , @apol wrote:
  
  > Let's add it when the application exists?
  
  
  We should do it beforehand so the app gets the proper Breeze icon on launch 
day.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21169

To: trickyricky26, hein, #vdg
Cc: ngraham, apol, kde-frameworks-devel, hein, michaelh, bruns

D21169: Add app icon for the Kirogi Drone control app

2019-05-13 Thread Eike Hein 
hein added a comment.


  @trickyricky26 It's great! What do you think about adding the detailed SVG as 
256 version?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21169

To: trickyricky26, hein, #vdg
Cc: apol, kde-frameworks-devel, hein, michaelh, ngraham, bruns

D21169: Add app icon for the Kirogi Drone control app

2019-05-12 Thread Aleix Pol Gonzalez 
apol added a comment.


  Let's add it when the application exists?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21169

To: trickyricky26, hein, #vdg
Cc: apol, kde-frameworks-devel, hein, michaelh, ngraham, bruns

D21169: Add app icon for the Kirogi Drone control app

2019-05-12 Thread TrickyRicky 
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21169

To: trickyricky26, hein, #vdg
Cc: kde-frameworks-devel, hein, michaelh, ngraham, bruns

D21169: Add app icon for the Kirogi Drone control app

2019-05-12 Thread TrickyRicky 
trickyricky26 created this revision.
trickyricky26 added a reviewer: hein.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REVISION SUMMARY
  Adds an app icon for @hein's upcoming Kirogi app.

REPOSITORY
  R266 Breeze Icons

BRANCH
  kirogi-app-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21169

AFFECTED FILES
  icons-dark/apps/48/kirogi.svg
  icons/apps/48/kirogi.svg

To: trickyricky26, hein
Cc: kde-frameworks-devel, hein, michaelh, ngraham, bruns