D21197: [KCoreDirLister] Remove assert in reinsert method

dfaure added a comment. @chinmoyr D23875 fixes the crash, I suggest to abandon this change request. We can discuss it again if someone manages to hit the assert again, in a different scenario :-) REPOSITORY R241 KIO REVISION DETAIL https://phabricato

D21197: [KCoreDirLister] Remove assert in reinsert method

dfaure added a comment. Can you look into adding a unittest for the case that hits the assert? As you say, this code isn't easy... but the unittest is quite comprehensive (although never enough, as proven by this). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21197

D21197: [KCoreDirLister] Remove assert in reinsert method

ngraham added reviewers: Frameworks, pino, elvisangelaccio, apol. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21197 To: chinmoyr, dfaure, #frameworks, pino, elvisangelaccio, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21197: [KCoreDirLister] Remove assert in reinsert method

chinmoyr created this revision. chinmoyr added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY Here I am trying to fix #405461. We reach this assertion in reinsert() after we cr