D21289: Fix: Use default indentation mode for new files

2019-05-19 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:11fb4c4d5e10: Fix: Use default indentation mode for new 
files (authored by dhaumann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21289?vs=58296=58300

REVISION DETAIL
  https://phabricator.kde.org/D21289

AFFECTED FILES
  src/document/katedocument.cpp

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D21289: Fix: Use default indentation mode for new files

2019-05-19 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  > ok
  

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-default-indent-mode

REVISION DETAIL
  https://phabricator.kde.org/D21289

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D21289: Fix: Use default indentation mode for new files

2019-05-19 Thread Dominik Haumann
dhaumann updated this revision to Diff 58296.
dhaumann added a comment.


  - Use updateConfig() to set indentation mode

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21289?vs=58294=58296

BRANCH
  fix-default-indent-mode

REVISION DETAIL
  https://phabricator.kde.org/D21289

AFFECTED FILES
  src/document/katedocument.cpp

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D21289: Fix: Use default indentation mode for new files

2019-05-19 Thread Christoph Cullmann
cullmann added a comment.


  Hmm, perhaps updateConfig would be better to not miss other stuff.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21289

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D21289: Fix: Use default indentation mode for new files

2019-05-19 Thread Dominik Haumann
dhaumann added a comment.


  Alternatively, we could call updateConfig() at the end of the KateDocument 
constructor which does - among other things - the same.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21289

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D21289: Fix: Use default indentation mode for new files

2019-05-19 Thread Dominik Haumann
dhaumann created this revision.
dhaumann added a reviewer: cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  BUG: 375502

TEST PLAN
  make && make test

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-default-indent-mode

REVISION DETAIL
  https://phabricator.kde.org/D21289

AFFECTED FILES
  src/document/katedocument.cpp

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann