D21293: Markdown: Use color with higher contrast for lists

[gregormi]

gregormi added a comment.


  In D21293#467150 , @dhaumann wrote:
  
  > New color is red: F6835074: Screenshot_20190519_175848.png 

  >
  > @gregormi If you want other colors, please propose them yourself :-)
  
  
  Thanks. Let's see how it works out.
  
  Regarding the screenshot, I see that "code 1, code2" is also the same orange 
as list items previously were. I think it would be better to change that as 
well, e.g. to blue as in "block quote" but a bit darker.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D21293

To: dhaumann, cullmann, gregormi
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21293: Markdown: Use color with higher contrast for lists

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:7be1380c52a8: Markdown: Use color with higher contrast 
for lists (authored by dhaumann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21293?vs=58308=58309

REVISION DETAIL
  https://phabricator.kde.org/D21293

AFFECTED FILES
  autotests/html/basic.markdown.html
  autotests/html/test.markdown.html
  data/syntax/markdown.xml

To: dhaumann, cullmann, gregormi
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21293: Markdown: Use color with higher contrast for lists

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Looks ok for me.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  improve-markdown-colors

REVISION DETAIL
  https://phabricator.kde.org/D21293

To: dhaumann, cullmann, gregormi
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21293: Markdown: Use color with higher contrast for lists

[Dominik Haumann]

dhaumann added a comment.


  New color is red: F6835074: Screenshot_20190519_175848.png 

  
  @gregormi If you want other colors, please propose them yourself :-)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D21293

To: dhaumann, cullmann, gregormi
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21293: Markdown: Use color with higher contrast for lists

[Dominik Haumann]

dhaumann created this revision.
dhaumann added reviewers: cullmann, gregormi.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  BUG: 405824
  FIXED-IN: 5.59

TEST PLAN
  make && make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  improve-markdown-colors

REVISION DETAIL
  https://phabricator.kde.org/D21293

AFFECTED FILES
  autotests/html/basic.markdown.html
  autotests/html/test.markdown.html
  data/syntax/markdown.xml

To: dhaumann, cullmann, gregormi
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann