jpoelen added a comment.
OK I understand. Initially I had not changed the version number of txsh.xml
and it is based on the reference in
`/usr/share/org.kde.syntax-highlighting/syntax/index.katesyntax` rather than in
the repository.
And the fact that the versions in the index file were
cullmann added a comment.
Actually the resource should be recreated on syntax file changes and be used.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D21421
To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kde-frameworks-devel,
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:4d2329e3f63e: Tcsh: fix operators and keywords (authored
by jpoelen).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21421?vs=58696=58742
REVISION
jpoelen added a comment.
I forgot to ask about running the tests. Is it normal that system syntax
files take precedence if we have an `index.katesyntax`? Currently I have to run
the tests by setting the environment variable `XDG_DATA_DIRS`.
REPOSITORY
R216 Syntax Highlighting
BRANCH
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Change looks reasonable + test case => thanks, please push
REPOSITORY
R216 Syntax Highlighting
BRANCH
fix_tcsh (branched from master)
REVISION DETAIL
jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks.
jpoelen requested review of this revision.
REVISION SUMMARY
- missing `foreach` and `end`
- fix folding with
