D21563: Fix empty pages in print preview and lines printed twice

hoffmannrobert added a comment. In D21563#584484 , @hoffmannrobert wrote: > In D21563#584218 , @dhaumann wrote: > > > @hoffmannrobert: Are you maybe also interested in looking into

D21563: Fix empty pages in print preview and lines printed twice

hoffmannrobert added a comment. In D21563#584220 , @dhaumann wrote: > @hoffmannrobert: by the way, looking at your phabricator activity, you should get a KDE contributor account, if you don't have one already. I applied for one and added

D21563: Fix empty pages in print preview and lines printed twice

hoffmannrobert added a comment. In D21563#584218 , @dhaumann wrote: > @hoffmannrobert: Are you maybe also interested in looking into https://bugs.kde.org/show_bug.cgi?id=415570 ? It's again about printing, this time about the very last line

D21563: Fix empty pages in print preview and lines printed twice

dhaumann added a comment. @hoffmannrobert: by the way, looking at your phabricator activity, you should get a KDE contributor account, if you don't have one already. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21563 To: hoffmannrobert, #kate, #ktexteditor,

D21563: Fix empty pages in print preview and lines printed twice

dhaumann added a comment. @hoffmannrobert: Are you maybe also interested in looking into https://bugs.kde.org/show_bug.cgi?id=415570 ? It's again about printing, this time about the very last line that seems to be wrong... REPOSITORY R39 KTextEditor REVISION DETAIL

D21563: Fix empty pages in print preview and lines printed twice

dhaumann closed this revision. dhaumann added a comment. Fixed for KF 5.60 with commit 6bbbe6aa51c0a293a58dbca6223e37a73ce32122, thanks for the patch - keep it coming! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21563 To: hoffmannrobert, #kate, #ktexteditor,

D21563: Fix empty pages in print preview and lines printed twice

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I just tested kwrite from master with Qt 5.12.0, and printing was completely broken. It even printed on Letter even though I specified A4 paper. A Qt update to Qt 5.12.3 fixed this -

D21563: Fix empty pages in print preview and lines printed twice

hoffmannrobert added a comment. In D21563#487947 , @cullmann wrote: > I tried to reproduce the issue with and without this fix but I somehow fail. > Has somebody else more luck? Try with long log files like boot.log, dmesg.log or

D21563: Fix empty pages in print preview and lines printed twice

dhaumann added a comment. I will test tomorrow ;) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21563 To: hoffmannrobert, #kate, #ktexteditor Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, bruns, demsking,

D21563: Fix empty pages in print preview and lines printed twice

cullmann added a comment. I tried to reproduce the issue with and without this fix but I somehow fail. Has somebody else more luck? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21563 To: hoffmannrobert, #kate, #ktexteditor Cc: cullmann, dhaumann, ngraham,

D21563: Fix empty pages in print preview and lines printed twice

ngraham edited the summary of this revision. ngraham added reviewers: Kate, KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21563 To: hoffmannrobert, #kate, #ktexteditor Cc: dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, domson,

D21563: Fix empty pages in print preview and lines printed twice

dhaumann added a comment. Many years ago I also stumbled over this bug, and I know for sure it never was fixed. If this fix really works then this would be really great! That said I have not yet tried the patch but am positive to get this in soon! REPOSITORY R39 KTextEditor REVISION

D21563: Fix empty pages in print preview and lines printed twice

hoffmannrobert added a comment. It fixes this bug: https://bugs.kde.org/show_bug.cgi?id=348598 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21563 To: hoffmannrobert Cc: ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, bruns, demsking,

D21563: Fix empty pages in print preview and lines printed twice

hoffmannrobert added a comment. In D21563#473734 , @ngraham wrote: > Fixes https://bugs.kde.org/show_bug.cgi?id=376270? No, that's something different. That is apparently a duplicate of https://bugs.kde.org/show_bug.cgi?id=391678 which

D21563: Fix empty pages in print preview and lines printed twice

ngraham added a comment. Fixes https://bugs.kde.org/show_bug.cgi?id=376270? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21563 To: hoffmannrobert Cc: ngraham, kwrite-devel, kde-frameworks-devel, domson, michaelh, bruns, demsking, cullmann, sars, dhaumann

D21563: Fix empty pages in print preview and lines printed twice

hoffmannrobert created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY There were errors if a page's last line is too long and needs to be wrapped into two