ndavis requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D21656
To: ognarb, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns
ndavis added a comment.
I just tried the patch on my own computer and I noticed a few more things
that need to be changed:
- The canvas size is 128x128 px when it should be 48x48
- Strokes need to be converted to paths ( [Ctrl] + [Alt] + [c] ). Strokes
don't always look correct in
ognarb updated this revision to Diff 59720.
ognarb added a comment.
Use more round corner.
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21656?vs=59707=59720
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D21656
AFFECTED FILES
ognarb edited the test plan for this revision.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D21656
To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns
ognarb edited the test plan for this revision.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D21656
To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns
ognarb edited the test plan for this revision.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D21656
To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns
ognarb updated this revision to Diff 59707.
ognarb added a comment.
Change color of some points
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21656?vs=59706=59707
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D21656
AFFECTED FILES
ognarb updated this revision to Diff 59706.
ognarb added a comment.
Still works in progress (need to add the gradiend) but some improvement
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21656?vs=59372=59706
BRANCH
master
REVISION DETAIL
ngraham added a comment.
Also please add a one-pixel hard bottom shadow.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D21656
To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns
ndavis added a comment.
We don't normally do the gloss wave in Breeze. That's more of a Tango/Oxygen
thing. How about adding some holes instead to make it look more like the real
thing?
https://www.gamesworld.com.au/wp-content/uploads/2015/10/cardinal-four-in-a-row.jpg
Just some ideas:
ognarb updated this revision to Diff 59372.
ognarb added a comment.
Crop shadow
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21656?vs=59371=59372
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D21656
AFFECTED FILES
ognarb edited the test plan for this revision.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D21656
To: ognarb, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
ognarb edited the test plan for this revision.
ognarb added a reviewer: VDG.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D21656
To: ognarb, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
ognarb created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ognarb requested review of this revision.
REPOSITORY
R266 Breeze Icons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D21656
AFFECTED FILES
14 matches
Mail list logo
