D21660: remove dbus for windows build and change audio dep logic

habacker added a comment. In D21660#565205 , @cullmann wrote: > That is bad, then this must be fixed. > That should happen on Windows, too. BTW: Does starting slaves on Linux kills started slave after slave timeout occurs, which is

D21660: remove dbus for windows build and change audio dep logic

cullmann added a comment. That is bad, then this must be fixed. That should happen on Windows, too. Just like it works nicely on macOS. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: cullmann, habacker,

D21660: remove dbus for windows build and change audio dep logic

habacker added a comment. In D21660#565113 , @cullmann wrote: > No, not really, I fixed that long ago, we auto-detect this and use the KDE_FORK_SLAVES code paths for that > > static bool forkSlaves() but this function is only called

D21660: remove dbus for windows build and change audio dep logic

cullmann added a comment. No, not really, I fixed that long ago, we auto-detect this and use the KDE_FORK_SLAVES code paths for that see in slave.cpp static bool forkSlaves() { // In such case we start the slave via QProcess. // It's possible to force this by

D21660: remove dbus for windows build and change audio dep logic

habacker added a comment. In D21660#565110 , @cullmann wrote: > kio doesn't require dbus for the normal slave stuff. > It can be that it requires it for the kcookie or auth stuff. klauncher is used to launch kio slaves. In the main()

D21660: remove dbus for windows build and change audio dep logic

cullmann added a comment. kio doesn't require dbus for the normal slave stuff. It can be that it requires it for the kcookie or auth stuff. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: cullmann, habacker,

D21660: remove dbus for windows build and change audio dep logic

habacker added a comment. In D21660#563560 , @bcooksley wrote: > Considering that D-Bus doesn't really belong on Windows, KDE uses dbus for many internal services. On a recent linux system I see the following KDE services in dbus

D21660: remove dbus for windows build and change audio dep logic

cullmann added a comment. +1 for no dbus on Windows! REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: cullmann, habacker, aspotashev, bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, GB_2,

D21660: remove dbus for windows build and change audio dep logic

bcooksley added a comment. Considering that D-Bus doesn't really belong on Windows, and has been known to cause security software (such as anti-malware packages) to generate false positives in the past, we really should avoid D-Bus completely if at all possible on Windows. For standalone

D21660: remove dbus for windows build and change audio dep logic

habacker added a comment. In D21660#563425 , @bcooksley wrote: > If tests launch D-Bus Daemon, then they will cause the CI system to jam as CTest will wait indefinitely for dbus-daemon to exit. There is a fix for this issue, see

D21660: remove dbus for windows build and change audio dep logic

bcooksley added a comment. If tests launch D-Bus Daemon, then they will cause the CI system to jam as CTest will wait indefinitely for dbus-daemon to exit. D-Bus should not be used under any circumstances on Windows. REPOSITORY R289 KNotifications REVISION DETAIL

D21660: remove dbus for windows build and change audio dep logic

habacker added a comment. In D21660#481421 , @bcooksley wrote: > With regards to Windows, please note that any unit test which depends on calls that involve D-Bus on the CI system will likely lead to that test hanging because dbus-daemon is

D21660: remove dbus for windows build and change audio dep logic

brute4s99 added a comment. sorry about that. I'll find a better solution that doesn't break builds  REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: aspotashev, bcooksley, apol, nicolasfella,

D21660: remove dbus for windows build and change audio dep logic

aspotashev added a comment. This broke some public APIs on Windows: since Qt5DBus is not being "imported" by CMake, a group of .cpp files is not being compiled, see e.g. https://cgit.kde.org/knotifications.git/tree/src/CMakeLists.txt#n25 . Thus e.g. class KStatusNotifierItem implementation

D21660: remove dbus for windows build and change audio dep logic

This revision was automatically updated to reflect the committed changes. Closed by commit R289:be466180db21: remove dbus for windows build and change audio dep logic (authored by brute4s99). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D21660: remove dbus for windows build and change audio dep logic

brute4s99 added a comment. landing it REPOSITORY R289 KNotifications BRANCH arcpatch-D21660_1 REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham,

D21660: remove dbus for windows build and change audio dep logic

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH arcpatch-D21660_1 REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel,

D21660: remove dbus for windows build and change audio dep logic

brute4s99 marked 8 inline comments as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21660: remove dbus for windows build and change audio dep logic

brute4s99 updated this revision to Diff 61716. brute4s99 added a comment. updated REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21660?vs=61639=61716 BRANCH arcpatch-D21660_1 REVISION DETAIL https://phabricator.kde.org/D21660 AFFECTED FILES

D21660: remove dbus for windows build and change audio dep logic

nicolasfella requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n,

D21660: remove dbus for windows build and change audio dep logic

nicolasfella added inline comments. INLINE COMMENTS > CMakeLists.txt:40 > +if (NOT ANDROID) > +find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED DBus) > +else () Move it down to the audio logic, the if check is the same REPOSITORY R289 KNotifications BRANCH

D21660: remove dbus for windows build and change audio dep logic

brute4s99 retitled this revision from "remove dbus and change audio dep logic" to "remove dbus for windows build and change audio dep logic". REPOSITORY R289 KNotifications BRANCH arcpatch-D21660_1 REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella