D21672: [PowerStateMonitor] Be conservative when determining power state

[Nathaniel Graham]

ngraham added a comment.


  > Let's not argue but investigate and fix why this seemingly innocent patch 
caused the behavior described.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21672

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: broulik, romangg, kde-frameworks-devel, #baloo, LeGast00n, sbergeron, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D21672: [PowerStateMonitor] Be conservative when determining power state

[Roman Gilg]

romangg added a comment.


  The bug report was online for two weeks and it was categorized as Baloo bug. 
You had more than enough time to notice it.
  
  I hoped I wouldn't need to waste any more time on this issue besides the time 
I already had to spent for working around this bug for two weeks, but now I had 
to setup baloo compilation myself, had to git bisect it and had to inform you. 
And now above all this unnecessary shit I have to deal with your ego being 
damaged when I reverted one isolated three lines patch of yours. Good news for 
you: the revert didn't fix the problem after reboot what I noticed now after I 
did one. Just when I restart baloo there is no more spam. So you can try to 
find the right solution now or you can continue being angry for no reason 
whatsoever.
  
  Because guess what: you can revert the revert at any time or even better hand 
in a patch to fix the whole issue after all.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21672

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: broulik, romangg, kde-frameworks-devel, #baloo, LeGast00n, sbergeron, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D21672: [PowerStateMonitor] Be conservative when determining power state

[Stefan Brüns]

bruns added a comment.


  In D21672#496232 , @broulik wrote:
  
  > > Why don't you notify the relevant people first
  >
  > He kinda did by writing a bug report, but let's not argue but investigate 
and fix why this seemingly innocent patch caused the behavior described.
  
  
  He set me as assignee today and then submitted the reversion **3** minutes 
later.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21672

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: broulik, romangg, kde-frameworks-devel, #baloo, LeGast00n, sbergeron, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D21672: [PowerStateMonitor] Be conservative when determining power state

[Kai Uwe Broulik]

broulik added a comment.


  > Why don't you notify the relevant people first
  
  He kinda did by writing a bug report, but let's not argue but investigate and 
fix why this seemingly innocent patch caused the behavior described.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21672

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: broulik, romangg, kde-frameworks-devel, #baloo, LeGast00n, sbergeron, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D21672: [PowerStateMonitor] Be conservative when determining power state

[Stefan Brüns]

bruns added a comment.


  In D21672#496217 , @romangg wrote:
  
  > Reverted by d6d86cb86c 
 on 
master. See https://bugs.kde.org/show_bug.cgi?id=409405 for more info. Possibly 
a critical problem in released 5.60 @bruns.
  
  
  Why don't you notify the relevant people first and **then** submit a 
**review**.
  
  Just reverting a commit without reasoning, without review is just wrong.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21672

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: romangg, kde-frameworks-devel, #baloo, LeGast00n, sbergeron, fbampaloukas, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21672: [PowerStateMonitor] Be conservative when determining power state

[Roman Gilg]

romangg added a comment.


  Reverted by d6d86cb86c 
 on 
master. See https://bugs.kde.org/show_bug.cgi?id=409405 for more info. Possibly 
a critical problem in released 5.60 @bruns.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21672

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: romangg, kde-frameworks-devel, #baloo, LeGast00n, sbergeron, fbampaloukas, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21672: [PowerStateMonitor] Be conservative when determining power state

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:0e6f1c923782: [PowerStateMonitor] Be conservative when 
determining power state (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21672?vs=59409=59498

REVISION DETAIL
  https://phabricator.kde.org/D21672

AFFECTED FILES
  src/file/powerstatemonitor.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21672: [PowerStateMonitor] Be conservative when determining power state

[Igor Poboiko]

poboiko accepted this revision.
poboiko added a comment.
This revision is now accepted and ready to land.


  Makes sense to me

REPOSITORY
  R293 Baloo

BRANCH
  scheduler

REVISION DETAIL
  https://phabricator.kde.org/D21672

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21672: [PowerStateMonitor] Be conservative when determining power state

[Stefan Brüns]

bruns added reviewers: Baloo, ngraham, astippich, poboiko.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21672

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21672: [PowerStateMonitor] Be conservative when determining power state

[Stefan Brüns]

bruns created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  When the state defaults to AC-powered, the indexer may start some
  energy consuming tasks, only to stop these later when the pending
  DBus call finishes. Especially the content indexer can take a while
  to stop, until the current batch is finished.
  
  In case the DBus call fails AC-powered is assumed, to match the previous
  default.

TEST PLAN
  unplug AC power
  start baloo_file
  -> the content indexer no longer processes its first batch

REPOSITORY
  R293 Baloo

BRANCH
  scheduler

REVISION DETAIL
  https://phabricator.kde.org/D21672

AFFECTED FILES
  src/file/powerstatemonitor.cpp

To: bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams