D21703: [Transaction] Replace template for functor with std::function

2019-06-10 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:5b6fd8fe88b7: [Transaction] Replace template for functor with std::function (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21703?vs=59467=59512

D21703: [Transaction] Replace template for functor with std::function

2019-06-10 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yep, seems sensible. REPOSITORY R293 Baloo BRANCH cleanup REVISION DETAIL https://phabricator.kde.org/D21703 To: bruns, #baloo, ngraham, astippich, poboiko Cc:

D21703: [Transaction] Replace template for functor with std::function

2019-06-10 Thread Stefan Brüns
bruns added a comment. In D21703#477158 , @poboiko wrote: > I thought about it myself. I googled it a bit (i.e. here ) and saw that there might be some quite unwanted runtime

D21703: [Transaction] Replace template for functor with std::function

2019-06-10 Thread Igor Poboiko
poboiko added a comment. I thought about it myself. I googled it a bit (i.e. here ) and saw that there might be some quite unwanted runtime overhead because of using `std::function`. It might be negligible (since we're

D21703: [Transaction] Replace template for functor with std::function

2019-06-09 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The callback parameter has a specific type, it accepts a