D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

dfaure added a comment. (remember to remove the [WIP] from the commit log, if you still have it locally) REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D21783 To: chinmoyr, #vdg, #frameworks, dfaure Cc: mreeves, ngraham, kde-frameworks-devel,

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D21783 To: chinmoyr, #vdg, #frameworks, dfaure Cc: mreeves, ngraham, kde-frameworks-devel,

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr added inline comments. INLINE COMMENTS > dfaure wrote in slavebase.h:262 > Does this break API docs generation? Suddenly the /** ... */ comment is > separated from the enum. The comment didn't affect the doc generation. But the placement was awkward so I changed it. REPOSITORY

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr updated this revision to Diff 71754. chinmoyr added a comment. updated kf5 version. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21783?vs=71041=71754 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21783 AFFECTED FILES

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > slavebase.h:262 > */ > -enum MessageBoxType { QuestionYesNo = 1, WarningYesNo = 2, > WarningContinueCancel = 3, WarningYesNoCancel = 4, Information

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr updated this revision to Diff 71041. chinmoyr added a comment. Rebased, compiled and tested. Changes work as expected. Double checked file_unix.cpp. Would be a shame if it happens yet again. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I'm concerned that you didn't compile this (because of dependency issues, from what I gather), which means it's not tested either. I tried to compile it but it doesn't

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr added inline comments. INLINE COMMENTS > dfaure wrote in slaveinterface_p.h:56 > Please explain how, for when the time comes (in case you're not around to do > it). Removing each of its occurence (of which there are 3) and the surrounding `if`. I will add comments where its needed

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr updated this revision to Diff 71025. chinmoyr marked 10 inline comments as done. chinmoyr added a comment. Addressed the issues. Annotated code to be removed in KF6. My build env is outdated so I couldn't compile the new depracation macro. Copied as it is. REPOSITORY R241 KIO

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > slavebase.cpp:1525 > + > +#ifndef KIOCORE_NO_DEPRECATED > +PrivilegeOperationStatus SlaveBase::requestPrivilegeOperation() `#if

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr added inline comments. INLINE COMMENTS > dfaure wrote in jobuidelegateextension.h:279 > Sorry, you can't add a new virtual method to an exported+installed class. > > BIC rules (where "rules" is a noun, not a verb...) ;-) > > Possible solutions: > > - creating a new, separate, type of

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

ngraham accepted this revision as: VDG. ngraham added a comment. UI looks fine to me. @dfaure? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21783 To: chinmoyr, #vdg, #frameworks, dfaure Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr updated this revision to Diff 70914. chinmoyr marked 4 inline comments as done. chinmoyr added a comment. Addressed the issues. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21783?vs=67955=70914 BRANCH arcpatch-D21783 REVISION DETAIL

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

ngraham added a task: T8075: Fix security issues with KAuth support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21783 To: chinmoyr, #vdg, #frameworks, dfaure Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > jobuidelegateextension.h:279 > + */ > +virtual bool askPrivilegeOperationConfirmation(const QString > , > +

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr added inline comments. INLINE COMMENTS > dfaure wrote in slavebase.h:964 > Missing "m" prefix like the other members, but wait isn't this BIC? > Adding a new member to an exported class certainly is. This needs to go into > the SlaveBasePrivate class instead. Since we need

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr updated this revision to Diff 67955. chinmoyr marked 3 inline comments as done. chinmoyr added a comment. Addressed the comments. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21783?vs=59738=67955 BRANCH arcpatch-D21783 REVISION DETAIL

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

ngraham added a comment. Ping :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21783 To: chinmoyr, #vdg, #frameworks, dfaure Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

dfaure requested changes to this revision. dfaure added inline comments. INLINE COMMENTS > slavebase.cpp:1511 > +KIO_DATA << d->m_warningCaption << d->m_warningMessage << > privilegeOperationDetails; > +send(INF_PRIVILEGE_CONF, data); > +if

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr planned changes to this revision. chinmoyr added a comment. TODO - Change the UI of the warning dialog - We still need more details REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21783 To: chinmoyr, #vdg, #frameworks, dfaure Cc: ngraham,

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

ngraham added a comment. Totally awesome :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21783 To: chinmoyr, #vdg, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr added a comment. In D21783#479187 , @ngraham wrote: > Thanks! Is this for T8075 ? Yes it is. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21783 To: chinmoyr, #vdg,

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

ngraham added a comment. Thanks! Is this for T8075 ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21783 To: chinmoyr, #vdg, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr updated this revision to Diff 59738. chinmoyr added a comment. Fix typo REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21783?vs=59737=59738 BRANCH warn REVISION DETAIL https://phabricator.kde.org/D21783 AFFECTED FILES

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr created this revision. chinmoyr added reviewers: VDG, Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY Currently it uses the dialog from D21782