D21783: Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  In D21783#581781 , @dfaure wrote:
  
  > @chinmoyr This change also breaks the corresponding unittest in CI, please 
take a look.
  >  
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/368/testReport/junit/projectroot/autotests/kiocore_privilegejobtest/
  
  
  Fixed. https://commits.kde.org/kio/a5b669263573dd7976c14f06b5c13f4da55dc6f0

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: bcooksley, mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D21783: Show more details in warning dialog shown before starting a privileged operation

[David Faure]

dfaure added a comment.


  @chinmoyr This change also breaks the corresponding unittest in CI, please 
take a look.
  
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/368/testReport/junit/projectroot/autotests/kiocore_privilegejobtest/

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: bcooksley, mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D21783: Show more details in warning dialog shown before starting a privileged operation

[David Faure]

dfaure added a comment.


  Fixed.
  
  https://commits.kde.org/kio/e2a38d7726e33f637576f254575c2c0743d205b8

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: bcooksley, mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D21783: Show more details in warning dialog shown before starting a privileged operation

[Ben Cooksley]

bcooksley added a comment.


  This changes FTBFS - see 
https://build.kde.org/job/Administration/job/Dependency%20Build%20Applications%20kf5-qt5%20SUSEQt5.12/47/
  There are currently a large number of Dependency Builds underway to correct 
changes in the tree as a consequence of Grantlee changing to be a first party 
repository, so this needs to be corrected urgently.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: bcooksley, mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D21783: Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:82aae02e2114: Show more details in warning dialog shown 
before starting a privileged operation (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21783?vs=71754&id=71981

REVISION DETAIL
  https://phabricator.kde.org/D21783

AFFECTED FILES
  autotests/kiotesthelper.h
  src/core/jobuidelegateextension.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface_p.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/jobuidelegate.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: Show more details in warning dialog shown before starting a privileged operation

[Nathaniel Graham]

ngraham retitled this revision from "[WIP]Show more details in warning dialog 
shown before starting a privileged operation" to "Show more details in warning 
dialog shown before starting a privileged operation".

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns