D21861: Add default variables for variables interface

cullmann added a comment. Ok, use now some self-defined env var with value set by the test itself, that should help on all operating systems. We don't need to check if HOME is ok. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21861 To: dhaumann, cullmann,

D21861: Add default variables for variables interface

This revision was automatically updated to reflect the committed changes. Closed by commit R39:f58c2af9b4de: fix unit test for all operating systems (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21861?vs=60614=60665#toc REPOSITORY R39 KTextEditor CHANGES

D21861: Add default variables for variables interface

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Actually my fix will only help for Unices, on Windows, this will still fail ;=) Either we guard that for Windows or we check there more env vars. REPOSITORY R39 KTextEditor

D21861: Add default variables for variables interface

This revision was automatically updated to reflect the committed changes. Closed by commit R39:cf85a33e1ff0: Add default variables for variables interface (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21861?vs=60393=60614 REVISION

D21861: Add default variables for variables interface

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH add-default-variables REVISION DETAIL https://phabricator.kde.org/D21861 To: dhaumann, cullmann, gregormi Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson,

D21861: Add default variables for variables interface

dhaumann edited the summary of this revision. dhaumann edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21861 To: dhaumann, cullmann, gregormi Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns,

D21861: Add default variables for variables interface

dhaumann updated this revision to Diff 60393. dhaumann added a comment. - Drop 'Current' prefix and improve documentation This should be good enough now, OK to commit? REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21861?vs=60384=60393 BRANCH

D21861: Add default variables for variables interface

gregormi added a comment. In D21861#484556 , @dhaumann wrote: > I'd like to drop the " Current" prefix in all the variables. It just makes the names longer and I don't see any value for users. Comments? There is no other Document than

D21861: Add default variables for variables interface

dhaumann added a comment. I'd like to drop the " Current" prefix in all the variables. It just makes the names longer and I don't see any value for users. Comments? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21861 To: dhaumann, cullmann, gregormi Cc:

D21861: Add default variables for variables interface

dhaumann updated this revision to Diff 60384. dhaumann added a comment. - Implement JS: variable expansion, e.g. %{JS:3+%{JS:2+1}} --> 6 - Variable expansion: Add unit tests REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21861?vs=59959=60384 BRANCH

D21861: Add default variables for variables interface

dhaumann added a comment. Btw, if there is a better place for initialization, I'd happily move the code to some other place. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21861 To: dhaumann, cullmann, gregormi Cc: kwrite-devel, kde-frameworks-devel, LeGast00n,

D21861: Add default variables for variables interface

dhaumann created this revision. dhaumann added reviewers: cullmann, gregormi. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY Add set of default variables that mostly match Qt