D21902: Calendar: add method to show event details

[Aleix Pol Gonzalez]

apol added a comment.


  LGTM +1

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21902

To: dvratil, mart, #frameworks, #plasma
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D21902: Calendar: add method to show event details

[Daniel Vrátil]

dvratil added a comment.


  Ping? :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21902

To: dvratil, mart, #frameworks, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D21902: Calendar: add method to show event details

[Daniel Vrátil]

dvratil updated this revision to Diff 76365.
dvratil added a comment.


  - Rebase to master

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21902?vs=60891=76365

BRANCH
  arcpatch-D21902

REVISION DETAIL
  https://phabricator.kde.org/D21902

AFFECTED FILES
  src/declarativeimports/calendar/daysmodel.cpp
  src/declarativeimports/calendar/daysmodel.h
  src/declarativeimports/calendar/eventdatadecorator.cpp
  src/declarativeimports/calendar/eventdatadecorator.h
  src/declarativeimports/calendar/eventpluginsmanager.cpp
  src/declarativeimports/calendar/eventpluginsmanager.h

To: dvratil, mart, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D21902: Calendar: add method to show event details

[Daniel Vrátil]

dvratil added a reviewer: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21902

To: dvratil, mart, #frameworks, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D21902: Calendar: add method to show event details

[Daniel Vrátil]

dvratil added a reviewer: Frameworks.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21902

To: dvratil, mart, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21902: Calendar: add method to show event details

[Daniel Vrátil]

dvratil added a comment.


  Ping?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21902

To: dvratil, mart, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21902: Calendar: add method to show event details

[Daniel Vrátil]

dvratil updated this revision to Diff 60891.
dvratil added a comment.


  Adapt to API changes in D21901 

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21902?vs=60066=60891

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21902

AFFECTED FILES
  src/declarativeimports/calendar/daysmodel.cpp
  src/declarativeimports/calendar/daysmodel.h
  src/declarativeimports/calendar/eventdatadecorator.cpp
  src/declarativeimports/calendar/eventdatadecorator.h
  src/declarativeimports/calendar/eventpluginsmanager.cpp
  src/declarativeimports/calendar/eventpluginsmanager.h

To: dvratil, mart
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21902: Calendar: add method to show event details

[Daniel Vrátil]

dvratil added a dependent revision: D21905: [Digital Clock] Open KOrganizer 
with event details on click.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21902

To: dvratil, mart
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21902: Calendar: add method to show event details

[Daniel Vrátil]

dvratil created this revision.
dvratil added a reviewer: mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dvratil requested review of this revision.

REVISION SUMMARY
  This extends the API to allow calendar UIs to request opening a detailed
  view of an event.
  
  Also contains a minor cleanup of unused m_eventPlugins member.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21902

AFFECTED FILES
  src/declarativeimports/calendar/daysmodel.cpp
  src/declarativeimports/calendar/daysmodel.h
  src/declarativeimports/calendar/eventdatadecorator.cpp
  src/declarativeimports/calendar/eventdatadecorator.h
  src/declarativeimports/calendar/eventpluginsmanager.cpp
  src/declarativeimports/calendar/eventpluginsmanager.h

To: dvratil, mart
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21902: Calendar: add method to show event details

[Daniel Vrátil]

dvratil added a dependency: D21901: Calendar events: allow plugins to show 
event details.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21902

To: dvratil, mart
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns