dfaure closed this revision.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D21959
To: hoffmannrobert, #frameworks, apol, dfaure
Cc: michaelweghorn, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2,
ragreen, Pitel, ZrenBot,
hoffmannrobert added a comment.
Can you please push it for me, I don't have commit access. Thanks.
REPOSITORY
R135 Integration for Qt applications in Plasma
BRANCH
fix_selectedNameFilter
REVISION DETAIL
https://phabricator.kde.org/D21959
To: hoffmannrobert, #frameworks, apol, dfaure
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R135 Integration for Qt applications in Plasma
BRANCH
fix_selectedNameFilter
REVISION DETAIL
https://phabricator.kde.org/D21959
To: hoffmannrobert, #frameworks, apol, dfaure
Cc: michaelweghorn,
hoffmannrobert marked an inline comment as done.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D21959
To: hoffmannrobert, #frameworks, apol, dfaure
Cc: michaelweghorn, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2,
ragreen,
hoffmannrobert updated this revision to Diff 60286.
hoffmannrobert added a comment.
- Remove redundant condition
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21959?vs=60217=60286
BRANCH
fix_selectedNameFilter
ngraham edited the test plan for this revision.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D21959
To: hoffmannrobert, #frameworks, apol, dfaure
Cc: michaelweghorn, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2,
ragreen,
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
+1 for the included unittest.
INLINE COMMENTS
> kdeplatformfiledialoghelper.cpp:80
> */
> -static QString kde2QtFilter(const QStringList , const QString )
> +static QString
ngraham added reviewers: Frameworks, apol, dfaure.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D21959
To: hoffmannrobert, #frameworks, apol, dfaure
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,
ZrenBot,