D22061: Add a logging category for logs warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R237:403c617eea56: Add a logging category for logs warnings (authored by meven). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22061?vs=63729&id=63735 REVISION DETAIL

D22061: Add a logging category for logs warnings

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R237 KConfig BRANCH arcpatch-D22061 REVISION DETAIL https://phabricator.kde.org/D22061 To: meven, #frameworks, apol, cgiboudeaux Cc: cgiboudeaux, mikeroyal

D22061: Add a logging category for logs warnings

meven added a comment. In D22061#511799 , @cgiboudeaux wrote: > ok, please change the remaining kconf/KCONF to kconfig/KCONFIG and it should be fine. Should be good now. Thank you for your feedback. REPOSITORY R237 KConfig REVISION

D22061: Add a logging category for logs warnings

meven updated this revision to Diff 63729. meven added a comment. Renamed kconf to kconfig, KCONF to KCONFIG, re-add the mistakenly removed categories file REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22061?vs=62903&id=63729 BRANCH arcpatch-D22061 RE

D22061: Add a logging category for logs warnings

cgiboudeaux added a comment. ok, please change the remaining kconf/KCONF to kconfig/KCONFIG and it should be fine. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22061 To: meven, #frameworks, apol Cc: cgiboudeaux, mikeroyal, apol, kde-frameworks-devel, LeGast00n, m

D22061: Add a logging category for logs warnings

meven marked 2 inline comments as done. meven added a comment. I have opted for the file name kconfig_core_log_settings.h for the log settings header file. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22061 To: meven, #frameworks, apol Cc: cgiboudeaux, mikeroyal,

D22061: Add a logging category for logs warnings

meven updated this revision to Diff 62903. meven added a comment. Rename kconf_desktop_debug.h to more appropriate kconfig_core_log_settings.h, do not run an unnecessary install REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22061?vs=61897&id=62903 BRANCH

D22061: Add a logging category for logs warnings

cgiboudeaux added inline comments. INLINE COMMENTS > CMakeLists.txt:102 > +install(FILES kconf.categories DESTINATION > ${KDE_INSTALL_LOGGINGCATEGORIESDIR}) > +install(FILES kconf.categories DESTINATION ${KDE_INSTALL_CONFDIR}) This line is not useful > CMakeLists.txt:17 > +ecm_qt_declare_log

D22061: Add a logging category for logs warnings

meven added a reviewer: apol. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22061 To: meven, #frameworks, apol Cc: mikeroyal, apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

meven updated this revision to Diff 61897. meven added a comment. Add a logging categorie, add context to logs REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22061?vs=60610&id=61897 BRANCH arcpatch-D22061 REVISION DETAIL https://phabricator.kde.org/D2

D22061: Add a logging category for logs warnings

meven edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22061 To: meven, #frameworks Cc: mikeroyal, apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

mikeroyal added a comment. This would be nice to have. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22061 To: meven, #frameworks Cc: mikeroyal, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

meven updated this revision to Diff 60610. meven added a comment. Add logging category for all kconfig core warnings message REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22061?vs=60558&id=60610 BRANCH master REVISION DETAIL https://phabricator.kde.o

D22061: Add a logging category for logs warnings

apol added a comment. The patch looks good to me. I see that you're just doing KDesktopFile, but there's many others available, can you port the rest too? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22061 To: meven, #frameworks Cc: apol, kde-frameworks-deve

D22061: Add a logging category for logs warnings

meven marked an inline comment as done. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22061 To: meven, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

meven edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22061 To: meven, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

meven updated this revision to Diff 60558. meven added a comment. Use KCONF_CORE_LOG as identifier and kf5.kconfig.core as category_name REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22061?vs=60547&id=60558 BRANCH master REVISION DETAIL https://phabr

D22061: Add a logging category for logs warnings

apol added inline comments. INLINE COMMENTS > CMakeLists.txt:19 > +IDENTIFIER KCONF_DESKTOP_LOG > +CATEGORY_NAME kf5.kconfig.desktop) > + This is for KF5ConfigCore, I'd call it kf5.kconfig.core. REPOSITORY R237 KConfig REVISION

D22061: Add a logging category for logs warnings

meven added a comment. Thank you very much again @apol for your guidance. I am not sure my naming scheme is ideal. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22061 To: meven, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

meven updated this revision to Diff 60547. meven added a comment. Removed blank line REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22061?vs=60546&id=60547 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22061 AFFECTED FILES src/core/CMa

D22061: Add a logging category for logs warnings

meven updated this revision to Diff 60546. meven added a comment. Use KCONF_DESKTOP_LOG to setup logging REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22061?vs=60545&id=60546 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22061 AFFECTED

D22061: Add a logging category for logs warnings

apol added inline comments. INLINE COMMENTS > kdesktopfile.h:27 > > +#include > +Q_DECLARE_LOGGING_CATEGORY(kconfigLoggingDesktop) Use ecm_qt_declare_logging_category from cmake. This should never be in header files too, or it would spill on applications otherwise. See for example how it's

D22061: Add a logging category for logs warnings

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Disable logs unless the logging category kf5.kconfig.kdesktopfile is enabled REPOSITORY