D22108: [TabBar] Remove exterior margins

2019-06-30 Thread Filip Fila
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:97272465a8b4: [TabBar] Remove exterior margins (authored 
by filipf).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22108?vs=60704=60896

REVISION DETAIL
  https://phabricator.kde.org/D22108

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/TabBar.qml

To: filipf, #vdg, #plasma, ngraham, ndavis
Cc: ndavis, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D22108: [TabBar] Remove exterior margins

2019-06-28 Thread Nathaniel Graham
ngraham accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  remove-tabbar-margins (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22108

To: filipf, #vdg, #plasma, ngraham, ndavis
Cc: ndavis, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D22108: [TabBar] Remove exterior margins

2019-06-27 Thread Noah Davis
ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  In D22108#487329 , @filipf wrote:
  
  > In D22108#487218 , @ndavis wrote:
  >
  > > 1+ visually. How does it look with a vertical panel?
  >
  >
  > Still not gliding on the line, but that should be resolved in Kickoff 
somehow:
  >
  > F6938487: image.png 
  
  
  That's a shame, but the patch doesn't introduce any visual regressions 
compared to git master, so I'll still accept this.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  remove-tabbar-margins (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22108

To: filipf, #vdg, #plasma, ngraham, ndavis
Cc: ndavis, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D22108: [TabBar] Remove exterior margins

2019-06-27 Thread Filip Fila
filipf added a comment.


  In D22108#487218 , @ndavis wrote:
  
  > 1+ visually. How does it look with a vertical panel?
  
  
  Still not gliding on the line, but that should be resolved in Kickoff somehow:
  
  F6938487: image.png 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D22108

To: filipf, #vdg, #plasma, ngraham
Cc: ndavis, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D22108: [TabBar] Remove exterior margins

2019-06-27 Thread Noah Davis
ndavis added a comment.


  1+ visually. How does it look with a vertical panel?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D22108

To: filipf, #vdg, #plasma, ngraham
Cc: ndavis, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D22108: [TabBar] Remove exterior margins

2019-06-27 Thread Filip Fila
filipf added a comment.


  In D22108#487140 , @apol wrote:
  
  > Makes sense to me, but why are the computer icons different? ^^'
  
  
  Some bug in Kickoff or with the icon, sometimes (maybe after you change a 
desktop theme) it shows the laptop icon, and then after a while the monitor 
icon. Should have made another screenshot but oh well :P

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D22108

To: filipf, #vdg, #plasma, ngraham
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D22108: [TabBar] Remove exterior margins

2019-06-27 Thread Aleix Pol Gonzalez
apol added a comment.


  Makes sense to me, but why are the computer icons different? ^^'

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D22108

To: filipf, #vdg, #plasma, ngraham
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D22108: [TabBar] Remove exterior margins

2019-06-26 Thread Filip Fila
filipf edited the test plan for this revision.
filipf added reviewers: VDG, Plasma, ngraham.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D22108

To: filipf, #vdg, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D22108: [TabBar] Remove exterior margins

2019-06-26 Thread Filip Fila
filipf created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This allows us to glide active tabbar indicators on lines, which we cannot do 
now in Kickoff due to this limitation in the control.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  remove-tabbar-margins (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22108

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/TabBar.qml

To: filipf
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns