D22257: performance, Qt API

2019-07-04 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R290:8e9fea2bc0bf: performance, Qt API (authored by apol). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22257?vs=61112=61121 REVISION DETAIL

D22257: performance, Qt API

2019-07-04 Thread Ben Cooksley
bcooksley added a comment. This change fails to build from source once committed. https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/35/changes#detail0 Please correct this urgently - at this very moment the CI system is proceeding through it's initial build

D22257: performance, Qt API

2019-07-04 Thread Marco Martin
mart accepted this revision. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D22257 To: apol, #frameworks, davidedmundson, mart Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22257: performance, Qt API

2019-07-04 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D22257 To: apol, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22257: performance, Qt API

2019-07-03 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Use proper appending API Don't look-up twice REPOSITORY R290 KPackage BRANCH