D22315: Add setting to enable/disable text drag-and-drop (on by default)

cullmann added a comment. Thanks! Keep the patches coming :=) Your recent improvements are highly appreciated! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22315 To: thomassc, #ktexteditor, cullmann Cc: ahmadsamir, dhaumann, cullmann, kwrite-devel, kd

D22315: Add setting to enable/disable text drag-and-drop (on by default)

This revision was automatically updated to reflect the committed changes. Closed by commit R39:c0321472330b: Add setting to enable/disable text drag-and-drop (on by default) (authored by thomassc). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22315?vs=612

D22315: Add setting to enable/disable text drag-and-drop (on by default)

cullmann added a comment. > I would say, merge this now. If somebody wants to fixup the label, one can do that later. === REPOSITORY R39 KTextEditor BRANCH text_drag_and_drop_setting REVISION DETA

D22315: Add setting to enable/disable text drag-and-drop (on by default)

ahmadsamir added a comment. IMHO, "Enable/Disable" is already implied by the checkbox :) REPOSITORY R39 KTextEditor BRANCH text_drag_and_drop_setting REVISION DETAIL https://phabricator.kde.org/D22315 To: thomassc, #ktexteditor, cullmann Cc: ahmadsamir, dhaumann, cullmann, kwrite-deve

D22315: Add setting to enable/disable text drag-and-drop (on by default)

cullmann added a comment. I have no issues with the label, matches the other in that category, not sure if "Enable" does make it better or worse. REPOSITORY R39 KTextEditor BRANCH text_drag_and_drop_setting REVISION DETAIL https://phabricator.kde.org/D22315 To: thomassc, #ktexteditor

D22315: Add setting to enable/disable text drag-and-drop (on by default)

thomassc added a comment. Thanks for having a look. Here is a screenshot of the config page with the new option on it (third from the bottom): F6991601: kate-config-text-drag-and-drop.png Do you think that the label there is okay as-is? Or shou

D22315: Add setting to enable/disable text drag-and-drop (on by default)

dhaumann added a comment. Good, I expected nothing less ;) REPOSITORY R39 KTextEditor BRANCH text_drag_and_drop_setting REVISION DETAIL https://phabricator.kde.org/D22315 To: thomassc, #ktexteditor, cullmann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, domson

D22315: Add setting to enable/disable text drag-and-drop (on by default)

cullmann added inline comments. INLINE COMMENTS > dhaumann wrote in kateconfig.h:986 > @cullmann Is the order here important? This changes all values of remaining > enums. The enum order doesn't matter, for all storage stuff the string keys are used. There shall only be no gaps. REPOSITORY

D22315: Add setting to enable/disable text drag-and-drop (on by default)

dhaumann added inline comments. INLINE COMMENTS > kateconfig.h:986 > ShowWordCount, > +TextDragAndDrop, > SmartCopyCut, @cullmann Is the order here important? This changes all values of remaining enums. REPOSITORY R39 KTextEditor BRANCH text_drag_and_drop_setting

D22315: Add setting to enable/disable text drag-and-drop (on by default)

dhaumann added a comment. When you do UI changes, please always add a screenshot. In this case of the changed config page :) REPOSITORY R39 KTextEditor BRANCH text_drag_and_drop_setting REVISION DETAIL https://phabricator.kde.org/D22315 To: thomassc, #ktexteditor, cullmann Cc: dhauma

D22315: Add setting to enable/disable text drag-and-drop (on by default)

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Think this is ok, given for some use cases one might want to disable it. Thanks for taking care! REPOSITORY R39 KTextEditor BRANCH text_drag_and_drop_setting REVISION DETAIL ht

D22315: Add setting to enable/disable text drag-and-drop (on by default)

thomassc added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22315 To: thomassc, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D22315: Add setting to enable/disable text drag-and-drop (on by default)

thomassc created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. thomassc requested review of this revision. REVISION SUMMARY This change adds a setting to enable or disable the ability to move the selected text by drag-and-d