D22339: Make sure solid backends are reentrant

bruns added a comment. I would have preferred this to only land when D22333 had been addressed fully, I assumed this required no further notice. So from a pure technical view, this indeed seems to be correct, but from an architectural view this

D22339: Make sure solid backends are reentrant

apol added a comment. In D22339#495116 , @lbeltrame wrote: > Why was this committed when changes were requested? Wasn't that the whole point of having reviews? Sorry, I thought all doubts had been resolved. No changes were requested.

D22339: Make sure solid backends are reentrant

davidedmundson added a comment. I don't endorse things being closed whilst there are still review comments, but replying purely on the tech side: > How do you guarantee *each thread local* copy now is connected to the right signals, i.e. the socket notifier for the mtab and inotify for

D22339: Make sure solid backends are reentrant

lbeltrame added a comment. Why was this committed when changes were requested? Wasn't that the whole point of having reviews? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D22339 To: apol, #frameworks, davidedmundson, bruns Cc: lbeltrame, bruns,

D22339: Make sure solid backends are reentrant

bruns added a comment. This is inacceptable! REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D22339 To: apol, #frameworks, davidedmundson, bruns Cc: bruns, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham

D22339: Make sure solid backends are reentrant

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R245:00abb4839abe: Make sure solid backends are reentrant (authored by apol). REPOSITORY R245 Solid CHANGES SINCE

D22339: Make sure solid backends are reentrant

apol added a comment. In D22339#494252 , @bruns wrote: > The invalidation has to be done per thread then as well, which you don't do. See fstabmanager.cpp As you can see in fstabmanager.cpp:40, FstabWatcher::instance() stays a

D22339: Make sure solid backends are reentrant

bruns added a comment. In D22339#494149 , @apol wrote: > In D22339#494142 , @bruns wrote: > > > How do you guarantee *each thread local* copy now is connected to the right signals, i.e. the socket

D22339: Make sure solid backends are reentrant

apol added a comment. In D22339#494142 , @bruns wrote: > How do you guarantee *each thread local* copy now is connected to the right signals, i.e. the socket notifier for the mtab and inotify for fstab? each backend will create things

D22339: Make sure solid backends are reentrant

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. How do you guarantee *each thread local* copy now is connected to the right signals, i.e. the socket notifier for the mtab and inotify for fstab? REPOSITORY R245 Solid REVISION

D22339: Make sure solid backends are reentrant

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D22339 To: apol, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22339: Make sure solid backends are reentrant

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Solid will create different backends for each separate thread but then some backends will