D22362: Port keystates to use QtWayland's generator

apol abandoned this revision. apol added a comment. Moved to invent for kwayland-server REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D22362 To: apol, #kwin Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D22362: Port keystates to use QtWayland's generator

apol updated this revision to Diff 67671. apol added a comment. Unnecessary change REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22362?vs=67670&id=67671 BRANCH arcpatch-D22362 REVISION DETAIL https://phabricator.kde.org/D22362 AFFECTED FILES CMak

D22362: Port keystates to use QtWayland's generator

apol updated this revision to Diff 67670. apol added a comment. Just don't use KWayland::Global Lets generated code do its thing already REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22362?vs=61478&id=67670 BRANCH arcpatch-D22362 REVISION DETAIL

D22362: Port keystates to use QtWayland's generator

apol added a comment. In D22362#493722 , @davidedmundson wrote: > As some background: > > At a recent Plasma sprint, one comment was that adding protocols to KWayland was an absolute pain involving writing a tonne of boiler plate. My experi

D22362: Port keystates to use QtWayland's generator

davidedmundson added a comment. As some background: At a recent Plasma sprint, one comment was that adding protocols to KWayland was an absolute pain involving writing a tonne of boiler plate. My experience adding a protocol to Qt was relatively painless. We said we'd try on a reall

D22362: Port keystates to use QtWayland's generator

apol added a comment. As discussed in the Plasma sprint. Removes some boilerplate code and turns it into C++ overrides. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D22362 To: apol, #kwin Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22362: Port keystates to use QtWayland's generator

apol updated this revision to Diff 61478. apol added a comment. --debug REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22362?vs=61477&id=61478 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22362 AFFECTED FILES CMakeLists.txt src/cli

D22362: Port keystates to use QtWayland's generator

apol created this revision. apol added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Saves us some of the boilerplate code TEST PLAN The plasmoid still works REPOSITORY R127 KW