D22362: Port keystates to use QtWayland's generator

2020-06-26 Thread Aleix Pol Gonzalez 
apol abandoned this revision.
apol added a comment.


  Moved to invent for kwayland-server

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D22362

To: apol, #kwin
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D22362: Port keystates to use QtWayland's generator

2019-10-10 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 67671.
apol added a comment.


  Unnecessary change

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22362?vs=67670=67671

BRANCH
  arcpatch-D22362

REVISION DETAIL
  https://phabricator.kde.org/D22362

AFFECTED FILES
  CMakeLists.txt
  src/client/CMakeLists.txt
  src/client/keystate.cpp
  src/server/CMakeLists.txt
  src/server/keystate_interface.cpp
  src/server/keystate_interface.h

To: apol, #kwin
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D22362: Port keystates to use QtWayland's generator

2019-10-10 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 67670.
apol added a comment.


  Just don't use KWayland::Global
  
  Lets generated code do its thing already

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22362?vs=61478=67670

BRANCH
  arcpatch-D22362

REVISION DETAIL
  https://phabricator.kde.org/D22362

AFFECTED FILES
  CMakeLists.txt
  src/client/CMakeLists.txt
  src/client/keystate.cpp
  src/server/CMakeLists.txt
  src/server/global_p.h
  src/server/keystate_interface.cpp
  src/server/keystate_interface.h

To: apol, #kwin
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D22362: Port keystates to use QtWayland's generator

2019-10-10 Thread Aleix Pol Gonzalez 
apol added a comment.


  In D22362#493722 , @davidedmundson 
wrote:
  
  > As some background:
  >
  > At a recent Plasma sprint, one comment was that adding protocols to 
KWayland was an absolute pain involving writing a tonne of boiler plate. My 
experience adding a protocol to Qt was relatively painless.
  >
  > We said we'd try on a really simple protocol.
  >
  > IMHO this looks encouraging.
  >
  > Obviously having a mix of styles isn't great, but something has to be first.
  >
  >  
  >
  > One thing we need to resolve is
  >
  > QtWaylandServer::org_kde_kwin_keystate
  >
  >   will call init which will call wl_global_create
  >   
  >
  > Global::Private will call wl_global_create
  >
  > Calling that twice is wrong.
  
  
  I was looking into this and realised it's not really easy to solve. The 
reason is that KWayland::Server::Global was designed to be able to expose the 
wl_global as if it was useful, but this is something you never do. The 
wl_global is private on the generated code so we can't access it. I'll provide 
a workaround for now to keep the conversation alive, but I'd say at least 
`operator wl_global*();` should get deprecated.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D22362

To: apol, #kwin
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D22362: Port keystates to use QtWayland's generator

2019-07-10 Thread David Edmundson 
davidedmundson added a comment.


  As some background:
  
  At a recent Plasma sprint, one comment was that adding protocols to KWayland 
was an absolute pain involving writing a tonne of boiler plate. My experience 
adding a protocol to Qt was relatively painless.
  
  We said we'd try on a really simple protocol.
  
  IMHO this looks encouraging.
  
  Obviously having a mix of styles isn't great, but something has to be first.
  
  
  
  One thing we need to resolve is
  
  QtWaylandServer::org_kde_kwin_keystate
   will call init which will call wl_global_create
  
  Global::Private will call wl_global_create
  
  Calling that twice is wrong.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D22362

To: apol, #kwin
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22362: Port keystates to use QtWayland's generator

2019-07-09 Thread Aleix Pol Gonzalez 
apol added a comment.


  As discussed in the Plasma sprint.
  Removes some boilerplate code and turns it into C++ overrides.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D22362

To: apol, #kwin
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22362: Port keystates to use QtWayland's generator

2019-07-09 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 61478.
apol added a comment.


  --debug

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22362?vs=61477=61478

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22362

AFFECTED FILES
  CMakeLists.txt
  src/client/CMakeLists.txt
  src/client/keystate.cpp
  src/server/CMakeLists.txt
  src/server/keystate_interface.cpp

To: apol, #kwin
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22362: Port keystates to use QtWayland's generator

2019-07-09 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Saves us some of the boilerplate code

TEST PLAN
  The plasmoid still works

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22362

AFFECTED FILES
  CMakeLists.txt
  src/client/CMakeLists.txt
  src/client/keystate.cpp
  src/server/CMakeLists.txt
  src/server/keystate_interface.cpp

To: apol, #kwin
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns