D22419: Fix can't enter directory error on some FTP servers with Turkish locale

2019-07-21 Thread Albert Astals Cid 
aacid closed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D22419

To: nxiss7, #frameworks, dfaure
Cc: dfaure, aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns

D22419: Fix can't enter directory error on some FTP servers with Turkish locale

2019-07-20 Thread NXiss7 
nxiss7 added a comment.


  In D22419#498730 , @aacid wrote:
  
  > nxisss can we have your real name and email for commit this to the codebase?
  
  
  Enes Selim
  nxi...@gmail.com

REVISION DETAIL
  https://phabricator.kde.org/D22419

To: nxiss7, #frameworks, dfaure
Cc: dfaure, aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns

D22419: Fix can't enter directory error on some FTP servers with Turkish locale

2019-07-20 Thread Albert Astals Cid 
aacid added a comment.


  nxisss can we have your real name and email for commit this to the codebase?

REVISION DETAIL
  https://phabricator.kde.org/D22419

To: nxiss7, #frameworks, dfaure
Cc: dfaure, aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns

D22419: Fix can't enter directory error on some FTP servers with Turkish locale

2019-07-20 Thread David Faure 
dfaure accepted this revision.

REVISION DETAIL
  https://phabricator.kde.org/D22419

To: nxiss7, #frameworks, dfaure
Cc: dfaure, aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns

D22419: Fix can't enter directory error on some FTP servers with Turkish locale

2019-07-20 Thread NXiss7 
nxiss7 updated this revision to Diff 62133.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22419?vs=62067&id=62133

REVISION DETAIL
  https://phabricator.kde.org/D22419

AFFECTED FILES
  src/ioslaves/ftp/ftp.cpp

To: nxiss7, #frameworks, dfaure
Cc: dfaure, aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns

D22419: Fix can't enter directory error on some FTP servers with Turkish locale

2019-07-20 Thread David Faure 
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  So it's a bug in the android FTP server? Nice ;-)
  
  They should learn from Qt, where QString::toUpper uses the C locale, and one 
has to use QLocale for locale-aware conversion.
  
  Please move the comment about Turkish locale 2 lines down, though, just above 
the uppercase LIST command, since that's what the comment is about.

REVISION DETAIL
  https://phabricator.kde.org/D22419

To: nxiss7, #frameworks, dfaure
Cc: dfaure, aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns

D22419: Fix can't enter directory error on some FTP servers with Turkish locale

2019-07-20 Thread NXiss7 
nxiss7 retitled this revision from "Fix can't enter directory error on Android 
FTP servers with Turkish locale" to "Fix can't enter directory error on some 
FTP servers with Turkish locale".

REVISION DETAIL
  https://phabricator.kde.org/D22419

To: nxiss7, #frameworks
Cc: aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns