D22477: With auto completion don't show completions that don't match from beginning of typed word

2020-01-31 Thread Ahmad Samir 
ahmadsamir abandoned this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D22477

To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, kossebau, mwolff, 
kfunk
Cc: brauch, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D22477: With auto completion don't show completions that don't match from beginning of typed word

2020-01-31 Thread Milian Wolff 
mwolff added a comment.


  I agree, this is a feature, not a bug. If people are annoyed, they are 
usually annoyed by other issues like the one shown by Sven

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D22477

To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, kossebau, mwolff, 
kfunk
Cc: brauch, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D22477: With auto completion don't show completions that don't match from beginning of typed word

2019-08-26 Thread Dominik Haumann 
dhaumann added a comment.


  Unconditionally removing this is not a good idea, since the feature 
significantly helps to discover API via code completion.
  
  In any case, feedback from @kfunk, @molff is needed here imho

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D22477

To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, kossebau, mwolff, 
kfunk
Cc: brauch, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D22477: With auto completion don't show completions that don't match from beginning of typed word

2019-08-25 Thread Christoph Cullmann 
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Actually, I did read the bug once more and tried it out myself.
  I think we should not unconditionally remove that feature.
  If you read the bug, one user complaints about it, another one likes this.
  If at all, we should make it an option, default like ATM.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D22477

To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, kossebau, mwolff, 
kfunk
Cc: brauch, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D22477: With auto completion don't show completions that don't match from beginning of typed word

2019-08-25 Thread Christoph Cullmann 
cullmann added a comment.


  Any feedback on that from others?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D22477

To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, kossebau, mwolff, 
kfunk
Cc: brauch, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D22477: With auto completion don't show completions that don't match from beginning of typed word

2019-08-03 Thread Ahmad Samir 
ahmadsamir marked 2 inline comments as done.
ahmadsamir added a comment.


  Ping.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D22477

To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, kossebau, mwolff, 
kfunk
Cc: brauch, kwrite-devel, kde-frameworks-devel, univerz, LeGast00n, sbergeron, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D22477: With auto completion don't show completions that don't match from beginning of typed word

2019-07-16 Thread Sven Brauch 
brauch added a comment.


  Also here, looks good to me, but I would wait for feedback from somebody else 
in addition. Thank you for working on this!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D22477

To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, kossebau, mwolff, 
kfunk
Cc: brauch, kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D22477: With auto completion don't show completions that don't match from beginning of typed word

2019-07-16 Thread Sven Brauch 
brauch added inline comments.

INLINE COMMENTS

> brauch wrote in katecompletionmodel.cpp:2029
> Maybe you want to set the flag here too?

Actually no, probably not. ;)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D22477

To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, kossebau, mwolff, 
kfunk
Cc: brauch, kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D22477: With auto completion don't show completions that don't match from beginning of typed word

2019-07-16 Thread Sven Brauch 
brauch added inline comments.

INLINE COMMENTS

> katecompletionmodel.cpp:2029
>  if (matchesAbbreviation(m_nameColumn, match, 
> model->matchCaseSensitivity())) {
>  matchCompletion = AbbreviationMatch;
>  }

Maybe you want to set the flag here too?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D22477

To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, kossebau, mwolff, 
kfunk
Cc: brauch, kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D22477: With auto completion don't show completions that don't match from beginning of typed word

2019-07-16 Thread Ahmad Samir 
ahmadsamir added a comment.


  In D22477#496214 , @brauch wrote:
  
  > I'm not sure if this solves the right problem.
  >
  > Where I notice this issue a lot is when typing "return". The keyword 
completion suggests "return", and when I want a newline, I complete the 
"return" first. This doesn't affect C++ (because of the trailing ";"), but it 
does affect other languages.
  >
  > I think this is pretty much the same issue. Maybe it should be solved by 
hiding the completion window if it was not explicitly invoked if there is any 
entry matching what you currently typed?
  >
  > Then typing Foo would not have the completion window open at all in the 
described case (thus solving your problem, as well as mine), and if you still 
wanted to complete BarFoo, you would press Ctrl+Space.
  
  
  
  
  In D22477#496214 , @brauch wrote:
  
  > I'm not sure if this solves the right problem.
  >
  > Where I notice this issue a lot is when typing "return". The keyword 
completion suggests "return", and when I want a newline, I complete the 
"return" first. This doesn't affect C++ (because of the trailing ";"), but it 
does affect other languages.
  >
  > I think this is pretty much the same issue. Maybe it should be solved by 
hiding the completion window if it was not explicitly invoked if there is any 
entry matching what you currently typed?
  
  
  Great idea. Done.
  
  > Then typing Foo would not have the completion window open at all in the 
described case (thus solving your problem, as well as mine), and if you still 
wanted to complete BarFoo, you would press Ctrl+Space.
  
  https://phabricator.kde.org/D22500

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D22477

To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, kossebau, mwolff, 
kfunk
Cc: brauch, kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D22477: With auto completion don't show completions that don't match from beginning of typed word

2019-07-16 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 61882.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  Take 2

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22477?vs=61881=61882

BRANCH
  less-trigger-happy-completions (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22477

AFFECTED FILES
  src/completion/katecompletionmodel.cpp
  src/completion/katecompletionmodel.h

To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, kossebau, mwolff, 
kfunk
Cc: brauch, kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D22477: With auto completion don't show completions that don't match from beginning of typed word

2019-07-16 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 61881.
ahmadsamir retitled this revision from "Add a config to only show completions 
matching word beginning" to "With auto completion don't show completions that 
don't match from beginning of typed word".
ahmadsamir edited the summary of this revision.
ahmadsamir edited the test plan for this revision.
ahmadsamir added a comment.


  Ver-bloody-batim

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22477?vs=61879=61881

BRANCH
  less-trigger-happy-completions (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22477

AFFECTED FILES
  src/completion/katecompletionmodel.cpp
  src/completion/katecompletionmodel.h

To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, kossebau, mwolff, 
kfunk
Cc: brauch, kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann