D22554: Finer No-Dbus on Windows

brute4s99 abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D22554: Finer No-Dbus on Windows

brute4s99 added a comment. closing this diff. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D22554: Finer No-Dbus on Windows

nicolasfella added a comment. @brute4s99 Is this still relevant? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D22554: Finer No-Dbus on Windows

brute4s99 updated this revision to Diff 62383. brute4s99 added a comment. let's put a pin in this for a while until I get a better solution for DBus on Windows REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22554?vs=62069=62383 BRANCH

D22554: Finer No-Dbus on Windows

nicolasfella added inline comments. INLINE COMMENTS > CMakeLists.txt:67 > + else() > +set(HAVE_DBUSMENUQT 0) > + endif() Here REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel,

D22554: Finer No-Dbus on Windows

brute4s99 marked an inline comment as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22554: Finer No-Dbus on Windows

brute4s99 updated this revision to Diff 62069. brute4s99 added a comment. updated REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22554?vs=62051=62069 BRANCH arcpatch-D22554 REVISION DETAIL https://phabricator.kde.org/D22554 AFFECTED FILES

D22554: Finer No-Dbus on Windows

brute4s99 added a comment. In D22554#497984 , @nicolasfella wrote: > Now HAVE_DBUSMENUQT won't be set. Previously it was set to 0 in this case Which line number are you referring to? REPOSITORY R289 KNotifications REVISION DETAIL

D22554: Finer No-Dbus on Windows

nicolasfella added a comment. Now HAVE_DBUSMENUQT won't be set. Previously it was set to 0 in this case REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel, LeGast00n, sbergeron,

D22554: Finer No-Dbus on Windows

andriusr added inline comments. INLINE COMMENTS > CMakeLists.txt:79 > + endif() > endif() > extra `endif()` ? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel, LeGast00n,

D22554: Finer No-Dbus on Windows

brute4s99 marked an inline comment as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22554: Finer No-Dbus on Windows

brute4s99 updated this revision to Diff 62051. brute4s99 added a comment. updated REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22554?vs=62048=62051 BRANCH arcpatch-D22554 REVISION DETAIL https://phabricator.kde.org/D22554 AFFECTED FILES

D22554: Finer No-Dbus on Windows

nicolasfella added inline comments. INLINE COMMENTS > CMakeLists.txt:70 > + > + if (TARGET Qt5::DBus) > +qt5_add_dbus_adaptor(knotifications_SRCS > org.kde.StatusNotifierItem.xml Now we have two checks for this REPOSITORY R289 KNotifications REVISION DETAIL

D22554: Finer No-Dbus on Windows

brute4s99 created this revision. brute4s99 added reviewers: nicolasfella, broulik. brute4s99 added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REVISION SUMMARY remove another dependency related to DBus from Windows builds