D22557: [IndexCleaner] ignore non-existent entries inside config

2019-07-22 Thread Igor Poboiko
poboiko closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D22557 To: poboiko, #baloo, bruns, ngraham Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22557: [IndexCleaner] ignore non-existent entries inside config

2019-07-19 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ah, right, of course. Makes sense. REPOSITORY R293 Baloo BRANCH no-indexcleaner-assert (branched from master) REVISION DETAIL https://phabricator.kde.org/D22557 To: poboiko,

D22557: [IndexCleaner] ignore non-existent entries inside config

2019-07-19 Thread Stefan BrĂ¼ns
bruns added a comment. In D22557#498002 , @ngraham wrote: > Shouldn't we make sure that entries get removed from the config file properly? An entry may become valid again. REPOSITORY R293 Baloo REVISION DETAIL

D22557: [IndexCleaner] ignore non-existent entries inside config

2019-07-19 Thread Nathaniel Graham
ngraham added a comment. Shouldn't we make sure that entries get removed from the config file properly? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D22557 To: poboiko, #baloo, bruns, ngraham Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson,

D22557: [IndexCleaner] ignore non-existent entries inside config

2019-07-19 Thread Igor Poboiko
poboiko created this revision. poboiko added reviewers: Baloo, bruns, ngraham. Herald added projects: Frameworks, Baloo. poboiko requested review of this revision. REVISION SUMMARY If a folder was added to include/excludeFolders and then removed, there will be a stale entry in the config, for