D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

This revision was automatically updated to reflect the committed changes. Closed by commit R240:685959c3fa78: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

apol added a comment. In D22580#499015 , @cgiboudeaux wrote: > KDE_INSTALL_USE_QT_SYS_PATHS has no effect on XDG_CONFIG_DIRS and XDG_DATA_DIRS or even the binary installation dir. > > Running prefix.sh is useful even if KDE_INSTALL_USE_QT_SY

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

cgiboudeaux added a comment. Thinking again: KDE_INSTALL_USE_QT_SYS_PATHS has no effect on XDG_CONFIG_DIRS and XDG_DATA_DIRS. Running prefix.sh is useful even if KDE_INSTALL_USE_QT_SYS_PATHS is true. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricato

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

cgiboudeaux accepted this revision. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D22580 To: apol, #frameworks, albertvaka, cgiboudeaux Cc: cgiboudeaux, albertvaka, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, mic

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

apol marked an inline comment as done. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D22580 To: apol, #frameworks, albertvaka Cc: cgiboudeaux, albertvaka, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngr

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

apol updated this revision to Diff 62169. apol added a comment. Support older cmakes REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22580?vs=62110&id=62169 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22580 AFFECTED FILES

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

cgiboudeaux added inline comments. INLINE COMMENTS > KDEInstallDirs.cmake:721 > +if(NOT KDE_INSTALL_USE_QT_SYS_PATHS) > +message(NOTICE "Installing in ${CMAKE_INSTALL_PREFIX}. Run > ${CMAKE_CURRENT_BINARY_DIR}/prefix.sh to set the environment for > ${CMAKE_PROJECT_NAME}.") > +endif() 'NOTI

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

albertvaka accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D22580 To: apol, #frameworks, albertvaka Cc: albertvaka, kde-frameworks-devel, kde-buildsystem, LeGast00n, sber

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

apol marked an inline comment as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22580 To: apol, #frameworks Cc: albertvaka, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

apol updated this revision to Diff 62110. apol added a comment. Improve wording REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22580?vs=62108&id=62110 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22580 AFFECTED FILES kde-m

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

albertvaka added inline comments. INLINE COMMENTS > KDEInstallDirs.cmake:721 > +if(NOT KDE_INSTALL_USE_QT_SYS_PATHS) > +message(NOTICE "Installing in ${CMAKE_INSTALL_PREFIX}, remember set the > environment. See ${CMAKE_CURRENT_BINARY_DIR}/prefix.sh") > +endif() Installing in `${CMAKE_INSTAL

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

apol created this revision. apol added a reviewer: Frameworks. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It's especially when KDE_INSTALL_USE_QT_SYS_PATHS=OFF that the