D22599: Make first and last name available separately

2019-11-12 Thread Jonah Brüchert
jbbgameich abandoned this revision.

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D22599

To: jbbgameich, #plasma:_mobile, apol
Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D22599: Make first and last name available separately

2019-07-21 Thread Aleix Pol Gonzalez
apol added a comment.


  In D22599#499008 , @pino wrote:
  
  > How would first + last name work, when
  >  a) you have multiple first names
  >  b) you have multiple last names
  >  c) you have only one "name" -- http://wookware.org/name.html
  
  
  As I see it, this is in case the user/front-end needs to treat them 
separately. Applications shouldn't put them together, that's why there's a 
separate NameProperty already.

REPOSITORY
  R307 KPeople

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22599

To: jbbgameich, #plasma:_mobile, apol
Cc: pino, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


D22599: Make first and last name available separately

2019-07-21 Thread Jonah Brüchert
jbbgameich added a comment.


  In case a, all first names would probably be in a string separated by spaces, 
same for multiple last names.
  In case c, I guess only the last name would be set maybe.
  
  I have been only working with the KContacts based vcard backend, where 
givenName and FamilyName could be mapped directly. I'm not quite sure what 
KContacts does in this cases though.

REPOSITORY
  R307 KPeople

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22599

To: jbbgameich, #plasma:_mobile, apol
Cc: pino, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


D22599: Make first and last name available separately

2019-07-21 Thread Pino Toscano
pino added a comment.


  How would first + last name work, when
  a) you have multiple first names
  b) you have multiple last names
  c) you have only one "name" -- http://wookware.org/name.html

REPOSITORY
  R307 KPeople

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22599

To: jbbgameich, #plasma:_mobile, apol
Cc: pino, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


D22599: Make first and last name available separately

2019-07-21 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R307 KPeople

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22599

To: jbbgameich, #plasma:_mobile, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


D22599: Make first and last name available separately

2019-07-20 Thread Jonah Brüchert
jbbgameich added reviewers: Plasma: Mobile, apol.

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D22599

To: jbbgameich, #plasma:_mobile, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


D22599: Make first and last name available separately

2019-07-20 Thread Jonah Brüchert
jbbgameich created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  Required for the Plasma Mobile phonebook app where both are separate fields

REPOSITORY
  R307 KPeople

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22599

AFFECTED FILES
  src/backends/abstractcontact.cpp
  src/backends/abstractcontact.h
  src/persondata.cpp
  src/persondata.h

To: jbbgameich
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns