D22653: Add view-qrcode icons

2019-07-24 Thread Mathis Brüchert 
mbruchert updated this revision to Diff 62460.
mbruchert added a comment.


  rename to view-barcode-qr as suggeste

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22653?vs=62346&id=62460

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22653

AFFECTED FILES
  icons-dark/actions/16/view-barcode-qr.svg
  icons-dark/actions/22/view-barcode-qr.svg
  icons-dark/actions/32/view-barcode-qr.svg
  icons/actions/16/view-barcode-qr.svg
  icons/actions/22/view-barcode-qr.svg
  icons/actions/32/view-barcode-qr.svg

To: mbruchert, #breeze, ndavis
Cc: broulik, ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22653: Add view-qrcode icons

2019-07-22 Thread Noah Davis 
ndavis added a comment.


  In D22653#500427 , @mbruchert 
wrote:
  
  > The blue corners are supposed to indicate that the QR-Code can be scanned.
  
  
  But aren't QR codes normally scannable?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22653

To: mbruchert, #breeze, ndavis
Cc: broulik, ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22653: Add view-qrcode icons

2019-07-22 Thread Noah Davis 
ndavis added a comment.


  In D22653#500471 , @broulik wrote:
  
  > How about `view-barcode-qr`? then we could potentially have specific 
`view-barcode-aztec` and also a fallback to `view-barcode`
  
  
  +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22653

To: mbruchert, #breeze, ndavis
Cc: broulik, ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22653: Add view-qrcode icons

2019-07-22 Thread Kai Uwe Broulik 
broulik added a comment.


  How about `view-barcode-qr`? then we could potentially have specific 
`view-barcode-aztec` and also a fallback to `view-barcode`

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22653

To: mbruchert, #breeze, ndavis
Cc: broulik, ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22653: Add view-qrcode icons

2019-07-22 Thread Mathis Brüchert 
mbruchert added a comment.


  The blue corners are supposed to indicate that the QR-Code can be scanned.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22653

To: mbruchert, #breeze, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22653: Add view-qrcode icons

2019-07-22 Thread Mathis Brüchert 
mbruchert updated this revision to Diff 62346.
mbruchert added a comment.


  Add icons to breeze-dark

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22653?vs=62344&id=62346

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22653

AFFECTED FILES
  icons-dark/actions/16/view-qrcode.svg
  icons-dark/actions/22/view-qrcode.svg
  icons-dark/actions/32/view-qrcode.svg
  icons/actions/16/view-qrcode.svg
  icons/actions/22/view-qrcode.svg
  icons/actions/32/view-qrcode.svg

To: mbruchert, #breeze, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22653: Add view-qrcode icons

2019-07-22 Thread Mathis Brüchert 
mbruchert updated this revision to Diff 62344.
mbruchert added a comment.


  Remove accidentially committed changes

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22653?vs=62343&id=62344

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22653

AFFECTED FILES
  icons/actions/16/view-qrcode.svg
  icons/actions/22/view-qrcode.svg
  icons/actions/32/view-qrcode.svg

To: mbruchert, #breeze, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22653: Add view-qrcode icons

2019-07-22 Thread Mathis Brüchert 
mbruchert updated this revision to Diff 62343.
mbruchert added a comment.


  Optimize and use css theme colors

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22653?vs=62318&id=62343

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22653

AFFECTED FILES
  icons/actions/16/view-qrcode.svg
  icons/actions/22/view-qrcode.svg
  icons/actions/32/view-qrcode.svg
  optimize-svg.sh

To: mbruchert, #breeze, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22653: Add view-qrcode icons

2019-07-22 Thread Noah Davis 
ndavis requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22653

To: mbruchert, #breeze, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22653: Add view-qrcode icons

2019-07-22 Thread Noah Davis 
ndavis added a comment.


  Hi! Thanks for the patch. There are few things I'd like you to change before 
I accept this.
  
  The icons need optimization and colorscheme support (see workflow tips). If 
you have questions or need help, feel free to ask.
  
  16px version:
  The margins are a pixel too wide on each side (see HIG). You could even fit 
in some random dots with the extra space that decreasing the margins would give 
you.
  F7077677: Screenshot_20190722_124543.png 

  
  32px:
  Not sure if this should be changed, but what is the reason for the blue 
corners?
  
  Make sure you read these:
  https://hig.kde.org/style/icon.html
  https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22653

To: mbruchert, #breeze
Cc: ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22653: Add view-qrcode icons

2019-07-22 Thread Mathis Brüchert 
mbruchert added a reviewer: Breeze.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22653

To: mbruchert, #breeze
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22653: Add view-qrcode icons

2019-07-22 Thread Mathis Brüchert 
mbruchert created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mbruchert requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22653

AFFECTED FILES
  icons/actions/16/view-qrcode.svg
  icons/actions/22/view-qrcode.svg
  icons/actions/32/view-qrcode.svg

To: mbruchert
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns