D22701: [kfileutils] Add isExecutableFile from KRun
nicolasfella abandoned this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D22701 To: nicolasfella, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D22701: [kfileutils] Add isExecutableFile from KRun
dfaure added a comment. I started to write a KIO::OpenUrlJob, as a core-only version of KRun. I think this method actually belongs there, because it means "can be executed by KRun" (or soon OpenUrlJob). In isolation I don't think this method is useful. I looked at all users of this method on lxr.kde.org and they all check this in connection with KRun. With this in mind, is there still a good reason to move it to kfileutils? INLINE COMMENTS > kfileutils.h:48 > + * -# The mime type must inherit application/x-executable, > application/x-executable-script or application/x-sharedlib. > + * To allow a script to run when the above rules are satisfied add the entry > + * @code Please remove the docu starting from this line to the end (i.e. 48-52), it describes KDE3 mimetype desktop files... REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D22701 To: nicolasfella, dfaure Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
D22701: [kfileutils] Add isExecutableFile from KRun
nicolasfella created this revision. nicolasfella added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY isExecutableFile is a useful function independent of KRun. Move it here so it can be used without pulling in all of KRun TEST PLAN builds REPOSITORY R244 KCoreAddons BRANCH exefile REVISION DETAIL https://phabricator.kde.org/D22701 AFFECTED FILES src/lib/io/kfileutils.cpp src/lib/io/kfileutils.h To: nicolasfella, dfaure Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
