D22758: Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R308:54e18b0d9b0d: Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly (authored by fvogt). REP

D22758: Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Edit. On testing this doesn't seem to work. See runnertest (with D23314 ) REPOSITORY R308 KRunner REVISION DETAIL https:/

D22758: Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner BRANCH betterhack REVISION DETAIL https://phabricator.kde.org/D22758 To: fvogt, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22758: Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly

fvogt created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY Currently KRunner uses QObjectDecorator wrongly and changing the design to fix that would not only be a lot of work, but a