D22780: KZip::openArchive: turn assert into if+return false

2019-07-27 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D22780 To: aacid, dfaure Cc: apol, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22780: KZip::openArchive: turn assert into if+return false

2019-07-27 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D22780 To: aacid, dfaure Cc: apol, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22780: KZip::openArchive: turn assert into if+return false

2019-07-27 Thread Albert Astals Cid
aacid updated this revision to Diff 62651. aacid added a comment. better tr string? REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22780?vs=62649=62651 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22780 AFFECTED FILES src/kzip.cpp

D22780: KZip::openArchive: turn assert into if+return false

2019-07-27 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY Asserting just because you opened a broken file is not nice REPOSITORY R243 KArchive BRANCH master REVISION DETAIL