D22800: Fix KService build on Android

2019-07-30 Thread Aleix Pol Gonzalez 
This revision was automatically updated to reflect the committed changes.
Closed by commit R309:99f21c7f7727: Fix KService build on Android (authored by 
apol).

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22800?vs=62709=62786

REVISION DETAIL
  https://phabricator.kde.org/D22800

AFFECTED FILES
  CMakeLists.txt
  src/kbuildsycoca/CMakeLists.txt
  src/kbuildsycoca/kbuildsycoca_main.cpp

To: apol, #frameworks, sitter, vkrause
Cc: vkrause, broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22800: Fix KService build on Android

2019-07-29 Thread Volker Krause 
vkrause accepted this revision.
vkrause added a comment.
This revision is now accepted and ready to land.


  Change looks fine to me, no opinion on the platform define style.

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22800

To: apol, #frameworks, sitter, vkrause
Cc: vkrause, broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22800: Fix KService build on Android

2019-07-29 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> broulik wrote in kbuildsycoca_main.cpp:26
> `Q_OS_ANDROID`?

Why?

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D22800

To: apol, #frameworks, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22800: Fix KService build on Android

2019-07-29 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> kbuildsycoca_main.cpp:26
>  #include 
> +#ifndef __ANDROID__
>  #include 

`Q_OS_ANDROID`?

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D22800

To: apol, #frameworks, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22800: Fix KService build on Android

2019-07-28 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added reviewers: Frameworks, sitter.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  DrKonqi isn't working there, so ifdef it out

TEST PLAN
  Built it

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22800

AFFECTED FILES
  CMakeLists.txt
  src/kbuildsycoca/CMakeLists.txt
  src/kbuildsycoca/kbuildsycoca_main.cpp

To: apol, #frameworks, sitter
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns