D22822: Add "users-other" icon

[Björn Feber]

GB_2 updated this revision to Diff 62966.
GB_2 added a comment.


  Rename icon to  `user-others`

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22822?vs=62782=62966

BRANCH
  add-users-other-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22822

AFFECTED FILES
  icons-dark/actions/16/user-others.svg
  icons-dark/actions/22/user-others.svg
  icons-dark/actions/24/user-others.svg
  icons/actions/16/user-others.svg
  icons/actions/22/user-others.svg
  icons/actions/24/user-others.svg

To: GB_2, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, sbergeron, michaelh, bruns

D22822: Add "users-other" icon

[Björn Feber]

GB_2 added a comment.


  In D22822#505557 , @ngraham wrote:
  
  > - Can we name it `user-others`? No other icon starts with `user`.
  
  
  Sure.
  
  > - Do we really need the 24px version?
  
  Well, the other user/group icons also have 24px versions, so why not :-)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22822

To: GB_2, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, sbergeron, michaelh, bruns

D22822: Add "users-other" icon

[Nathaniel Graham]

ngraham added a comment.


  Visually, it looks good to me! Two questions about the implementation details 
though:
  
  - Can we name it `user-others`? No other icon starts with `user`.
  - Do we really need the 24px version?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22822

To: GB_2, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, sbergeron, michaelh, bruns

D22822: Add "users-other" icon

[Noah Davis]

ndavis added a comment.


  I'll review this when I'm back from my vacation. I don't have my laptop with 
me.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22822

To: GB_2, #vdg, ndavis
Cc: kde-frameworks-devel, #vdg, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22822: Add "users-other" icon

[Filip Fila]

filipf added a reviewer: ndavis.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22822

To: GB_2, #vdg, ndavis
Cc: kde-frameworks-devel, #vdg, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22822: Add "users-other" icon

[Björn Feber]

GB_2 created this revision.
GB_2 added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  BUG: 407782
  
  Needed to represent permissions for other users.
  F7118835: users-other Icon.png 

TEST PLAN
  Search for `users-other` in Cuttlefish.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-users-other-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22822

AFFECTED FILES
  icons-dark/actions/16/users-other.svg
  icons-dark/actions/22/users-other.svg
  icons-dark/actions/24/users-other.svg
  icons/actions/16/users-other.svg
  icons/actions/22/users-other.svg
  icons/actions/24/users-other.svg

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, LeGast00n, sbergeron, michaelh, ngraham, bruns