D22868: Revamp Kirigami.AboutPage

[Nicolas Fella]

nicolasfella added a comment.


  can this be closed?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22868

To: hein, #frameworks, #vdg, mart, apol, ngraham, leinir, nicolasfella
Cc: nicolasfella, ngraham, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, apol, ahiemstra, davidedmundson, mart

D22868: Revamp Kirigami.AboutPage

[Eike Hein]

hein added a comment.


  I'll remove that part of the patch later tonight and talk Marco into fixing 
it differently.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22868

To: hein, #frameworks, #vdg, mart, apol, ngraham, leinir, nicolasfella
Cc: nicolasfella, ngraham, plasma-devel, fbampaloukas, domson, dkardarakos, 
apol, davidedmundson, mart, hein

D22868: Revamp Kirigami.AboutPage

[Nicolas Fella]

nicolasfella requested changes to this revision.
nicolasfella added a comment.
This revision now requires changes to proceed.


  This breaks the display of main actions on mobile

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22868

To: hein, #frameworks, #vdg, mart, apol, ngraham, leinir, nicolasfella
Cc: nicolasfella, ngraham, plasma-devel, fbampaloukas, domson, dkardarakos, 
apol, davidedmundson, mart, hein

D22868: Revamp Kirigami.AboutPage

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.


  While swapping out the card for straight up a rowlayout might[1] effectively 
look like a workaround for the weirdness in that bit... this really just looks 
better anyway ;) Go for it :D
  
  [1] to someone who's tried to fix that bit before - D18180 
 - not in general :) once this is landed, 
i'll abandon that diff

REPOSITORY
  R169 Kirigami

BRANCH
  aboutpage

REVISION DETAIL
  https://phabricator.kde.org/D22868

To: hein, #frameworks, #vdg, mart, apol, ngraham, leinir
Cc: ngraham, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D22868: Revamp Kirigami.AboutPage

[Eike Hein]

hein updated this revision to Diff 62883.
hein added a comment.


  Don't hit Kirigami.Label (deprecated)

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22868?vs=62880=62883

BRANCH
  aboutpage

REVISION DETAIL
  https://phabricator.kde.org/D22868

AFFECTED FILES
  src/controls/AboutPage.qml
  src/controls/Page.qml

To: hein, #frameworks, #vdg, mart, apol, ngraham, leinir
Cc: ngraham, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D22868: Revamp Kirigami.AboutPage

[Eike Hein]

hein added a reviewer: leinir.

REPOSITORY
  R169 Kirigami

BRANCH
  aboutpage

REVISION DETAIL
  https://phabricator.kde.org/D22868

To: hein, #frameworks, #vdg, mart, apol, ngraham, leinir
Cc: ngraham, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D22868: Revamp Kirigami.AboutPage

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Super duper better now.

REPOSITORY
  R169 Kirigami

BRANCH
  aboutpage

REVISION DETAIL
  https://phabricator.kde.org/D22868

To: hein, #frameworks, #vdg, mart, apol, ngraham
Cc: ngraham, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D22868: Revamp Kirigami.AboutPage

[Eike Hein]

hein added a comment.


  Discover:
  
  F7130049: Screenshot_20190801_100601.png 

  
  Material style:
  
  F7130053: Screenshot_20190801_100645.png 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22868

To: hein, #frameworks, #vdg, mart, apol
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D22868: Revamp Kirigami.AboutPage

[Eike Hein]

hein added a comment.


  Before:
  
  F7130036: Screenshot_20190801_15.png 

  
  After:
  
  F7130037: Screenshot_20190801_100033.png 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22868

To: hein, #frameworks, #vdg, mart, apol
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D22868: Revamp Kirigami.AboutPage

[Eike Hein]

hein created this revision.
hein added reviewers: Frameworks, VDG, mart, apol.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
hein requested review of this revision.

REVISION SUMMARY
  - Use a FormLayout to work nicely in both portrait and landscape orientations
  - Don't use an AbstractCard for the person delegate, it's very jarring in 
this design
  - Fix app description not having word wrap (breaks on portrait)
  - Improve inter-section spacing
  - Fix empty author email addresses showing as "Name <>"
  - Fix scrollbar length if a `Kirigami.Page` doesn't set any actions (and 
don't load a gigantic subtree of unnecessary objects into the page)
  - If an app uses `Kirigami.AbstractApplicationWindow` and doesn't have a 
`pageStack`, don't have the license delegate be a `LinkButton` that operates on 
one and causes an error
  - Add a fallback to KAboutData::componentName for the program icon - 
`KAboutData::programIconName` is deprecated, there's no QML accessor for its 
replacement `QGuiApplication::setWindowIcon` yet, but 
`KAboutData::programIconName` falls back to `componentName` already (it fails 
because `KAboutData::programIconName` isn't a qprop, but I don't feel like 
adding it to KCoreAddons for a deprecated thing while `componentName` is not 
deprecated)

REPOSITORY
  R169 Kirigami

BRANCH
  aboutpage

REVISION DETAIL
  https://phabricator.kde.org/D22868

AFFECTED FILES
  src/controls/AboutPage.qml
  src/controls/Page.qml

To: hein, #frameworks, #vdg, mart, apol
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein