This revision was automatically updated to reflect the committed changes.
Closed by commit R280:003f15910475: Include KDE* cmake macros first (authored
by arojas).
REPOSITORY
R280 Prison
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22915?vs=63054=63064
REVISION DETAIL
kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.
You might want to adapt the commit message/phab revision title perhaps,
noting that those three includes should be done first, as they want to
influence any other CMake code used by
arojas updated this revision to Diff 63054.
arojas added a reviewer: kossebau.
arojas added a comment.
Implement kossebau's suggestion
REPOSITORY
R280 Prison
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22915?vs=63042=63054
REVISION DETAIL
https://phabricator.kde.org/D22915
kossebau added a comment.
Even better would be to move this set of three to be the first macros to be
included (after having found ECM), and include any other macros only after that:
include(KDEInstallDirs)
include(KDECMakeSettings)
include(KDEFrameworkCompilerSettings
arojas created this revision.
arojas added a reviewer: apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
arojas requested review of this revision.
REVISION SUMMARY
ECMGeneratePriFile uses KDE_INSTALL_USE_QT_SYS_PATH, which is initialized in
